From: Sascha Hauer <s.hauer@pengutronix.de>
To: "menon.nishanth@gmail.com" <menon.nishanth@gmail.com>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: [PATCH v2] omap4: set voltage according to mpu freq
Date: Sat, 8 Jun 2013 15:21:38 +0200 [thread overview]
Message-ID: <20130608132138.GI32299@pengutronix.de> (raw)
In-Reply-To: <CAGo_u6rixBCzggcuLAfOLuxgTrzyDhY7ipf2garfTiDb_Ce0WA@mail.gmail.com>
On Thu, Jun 06, 2013 at 08:40:46AM -0500, menon.nishanth@gmail.com wrote:
> On Thu, Jun 6, 2013 at 7:47 AM, Jan Weitzel <j.weitzel@phytec.de> wrote:
> > +noinline int omap4460_scale_vcores(unsigned vsel0_pin, unsigned volt_mv)
> > +{
> > + void __iomem *base;
> > + u32 val = 0;
> > +
> > + /* For VC bypass only VCOREx_CGF_FORCE is necessary and
> > + * VCOREx_CFG_VOLTAGE changes can be discarded
> > + */
> > + writel(0, OMAP44XX_PRM_VC_CFG_I2C_MODE);
> > + writel(0x6026, OMAP44XX_PRM_VC_CFG_I2C_CLK);
> > +
> > + /* TPS - supplies vdd_mpu on 4460
> > + * Setup SET1 and SET0 with right values so that kernel
> > + * can use either of them based on its needs.
> > + */
> > +
> > + omap4_do_scale_tps62361(TPS62361_REG_ADDR_SET0, volt_mv);
> Just a nitpick - the general rule of TPS+OMAP4460 integration is *NOT*
> to program SET0 register. this is intended to be at boot voltage
> required to be used when reboot due to s/w controlled or h/w watchdog.
So this line should simply be removed?
Ok, this line is only moved and not introduced in this patch, so it
should be fine to apply this patch and leave this for a separate patch.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-06-08 13:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 11:51 [PATCH] " Jan Weitzel
2013-05-30 9:39 ` Sascha Hauer
2013-06-05 9:52 ` Jan Weitzel
2013-06-06 12:47 ` [PATCH v2] " Jan Weitzel
2013-06-06 13:40 ` menon.nishanth
2013-06-08 13:21 ` Sascha Hauer [this message]
2013-06-12 7:16 ` Jan Weitzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130608132138.GI32299@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=menon.nishanth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox