From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] console: fix new console registration
Date: Mon, 10 Jun 2013 14:59:15 +0200 [thread overview]
Message-ID: <20130610125915.GF27130@game.jcrosoft.org> (raw)
In-Reply-To: <1370806993-28524-1-git-send-email-s.trumtrar@pengutronix.de>
On 21:43 Sun 09 Jun , Steffen Trumtrar wrote:
> The console_register-function gets the baudrate from a kconfig parameter and
> sets the console accordingly, if a setbrg function is registered.
> Add the missing call to setbrg on the newly registered console to actually
> use the baudrate setting.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> common/console.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/common/console.c b/common/console.c
> index a0a06f6..abf5322 100644
> --- a/common/console.c
> +++ b/common/console.c
> @@ -147,6 +147,7 @@ int console_register(struct console_device *newcdev)
> newcdev->baudrate = CONFIG_BAUDRATE;
> dev_add_param_int(dev, "baudrate", console_baudrate_set,
> NULL, &newcdev->baudrate, "%u", newcdev);
> + newcdev->setbrg(newcdev, newcdev->baudrate);
this need to be done at the enable not the register
Best Regards,
J.
> }
>
> dev_add_param(dev, "active", console_std_set, NULL, 0);
> --
> 1.8.2.rc2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-06-10 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 19:43 Steffen Trumtrar
2013-06-10 12:59 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130610125915.GF27130@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox