* [PATCH] ARM: pcm038: Avoid warning if gadget support not compiled in
@ 2013-06-09 10:22 Alexander Shiyan
2013-06-11 15:27 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Shiyan @ 2013-06-09 10:22 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boards/pcm038/pcm038.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boards/pcm038/pcm038.c b/arch/arm/boards/pcm038/pcm038.c
index 49677c2..dec5164 100644
--- a/arch/arm/boards/pcm038/pcm038.c
+++ b/arch/arm/boards/pcm038/pcm038.c
@@ -328,7 +328,8 @@ static int pcm038_devices_init(void)
mdelay(1);
imx_gpio_mode(PE1_PF_USBOTG_STP);
- imx27_add_usbotg(&pcm038_otg_pdata);
+ if (IS_ENABLED(CONFIG_USB_GADGET_DRIVER_ARC))
+ imx27_add_usbotg(&pcm038_otg_pdata);
switch (bootsource_get()) {
case BOOTSOURCE_NAND:
--
1.8.1.5
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: pcm038: Avoid warning if gadget support not compiled in
2013-06-09 10:22 [PATCH] ARM: pcm038: Avoid warning if gadget support not compiled in Alexander Shiyan
@ 2013-06-11 15:27 ` Sascha Hauer
2013-06-11 15:54 ` Re[2]: " Alexander Shiyan
0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2013-06-11 15:27 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox
On Sun, Jun 09, 2013 at 02:22:41PM +0400, Alexander Shiyan wrote:
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/boards/pcm038/pcm038.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boards/pcm038/pcm038.c b/arch/arm/boards/pcm038/pcm038.c
> index 49677c2..dec5164 100644
> --- a/arch/arm/boards/pcm038/pcm038.c
> +++ b/arch/arm/boards/pcm038/pcm038.c
> @@ -328,7 +328,8 @@ static int pcm038_devices_init(void)
> mdelay(1);
> imx_gpio_mode(PE1_PF_USBOTG_STP);
>
> - imx27_add_usbotg(&pcm038_otg_pdata);
> + if (IS_ENABLED(CONFIG_USB_GADGET_DRIVER_ARC))
> + imx27_add_usbotg(&pcm038_otg_pdata);
What warning do you get without this patch?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re[2]: [PATCH] ARM: pcm038: Avoid warning if gadget support not compiled in
2013-06-11 15:27 ` Sascha Hauer
@ 2013-06-11 15:54 ` Alexander Shiyan
2013-06-17 7:12 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Shiyan @ 2013-06-11 15:54 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
> On Sun, Jun 09, 2013 at 02:22:41PM +0400, Alexander Shiyan wrote:
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> > arch/arm/boards/pcm038/pcm038.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boards/pcm038/pcm038.c b/arch/arm/boards/pcm038/pcm038.c
> > index 49677c2..dec5164 100644
> > --- a/arch/arm/boards/pcm038/pcm038.c
> > +++ b/arch/arm/boards/pcm038/pcm038.c
> > @@ -328,7 +328,8 @@ static int pcm038_devices_init(void)
> > mdelay(1);
> > imx_gpio_mode(PE1_PF_USBOTG_STP);
> >
> > - imx27_add_usbotg(&pcm038_otg_pdata);
> > + if (IS_ENABLED(CONFIG_USB_GADGET_DRIVER_ARC))
> > + imx27_add_usbotg(&pcm038_otg_pdata);
>
> What warning do you get without this patch?
Runtime warning "No supported role" from chipidea driver.
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: pcm038: Avoid warning if gadget support not compiled in
2013-06-11 15:54 ` Re[2]: " Alexander Shiyan
@ 2013-06-17 7:12 ` Sascha Hauer
0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2013-06-17 7:12 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox
On Tue, Jun 11, 2013 at 07:54:23PM +0400, Alexander Shiyan wrote:
> > On Sun, Jun 09, 2013 at 02:22:41PM +0400, Alexander Shiyan wrote:
> > >
> > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > ---
> > > arch/arm/boards/pcm038/pcm038.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boards/pcm038/pcm038.c b/arch/arm/boards/pcm038/pcm038.c
> > > index 49677c2..dec5164 100644
> > > --- a/arch/arm/boards/pcm038/pcm038.c
> > > +++ b/arch/arm/boards/pcm038/pcm038.c
> > > @@ -328,7 +328,8 @@ static int pcm038_devices_init(void)
> > > mdelay(1);
> > > imx_gpio_mode(PE1_PF_USBOTG_STP);
> > >
> > > - imx27_add_usbotg(&pcm038_otg_pdata);
> > > + if (IS_ENABLED(CONFIG_USB_GADGET_DRIVER_ARC))
> > > + imx27_add_usbotg(&pcm038_otg_pdata);
> >
> > What warning do you get without this patch?
>
> Runtime warning "No supported role" from chipidea driver.
Applied now, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-17 7:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-09 10:22 [PATCH] ARM: pcm038: Avoid warning if gadget support not compiled in Alexander Shiyan
2013-06-11 15:27 ` Sascha Hauer
2013-06-11 15:54 ` Re[2]: " Alexander Shiyan
2013-06-17 7:12 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox