mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: pcm038: Avoid warning if gadget support not compiled in
Date: Mon, 17 Jun 2013 09:12:25 +0200	[thread overview]
Message-ID: <20130617071225.GG32299@pengutronix.de> (raw)
In-Reply-To: <1370966063.553147631@f314.mail.ru>

On Tue, Jun 11, 2013 at 07:54:23PM +0400, Alexander Shiyan wrote:
> > On Sun, Jun 09, 2013 at 02:22:41PM +0400, Alexander Shiyan wrote:
> > > 
> > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > ---
> > >  arch/arm/boards/pcm038/pcm038.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/arm/boards/pcm038/pcm038.c b/arch/arm/boards/pcm038/pcm038.c
> > > index 49677c2..dec5164 100644
> > > --- a/arch/arm/boards/pcm038/pcm038.c
> > > +++ b/arch/arm/boards/pcm038/pcm038.c
> > > @@ -328,7 +328,8 @@ static int pcm038_devices_init(void)
> > >  	mdelay(1);
> > >  	imx_gpio_mode(PE1_PF_USBOTG_STP);
> > >  
> > > -	imx27_add_usbotg(&pcm038_otg_pdata);
> > > +	if (IS_ENABLED(CONFIG_USB_GADGET_DRIVER_ARC))
> > > +		imx27_add_usbotg(&pcm038_otg_pdata);
> > 
> > What warning do you get without this patch?
> 
> Runtime warning "No supported role" from chipidea driver.

Applied now, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2013-06-17  7:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-09 10:22 Alexander Shiyan
2013-06-11 15:27 ` Sascha Hauer
2013-06-11 15:54   ` Re[2]: " Alexander Shiyan
2013-06-17  7:12     ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130617071225.GG32299@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox