Re: [PATCH v6] omap4-fb: add driver

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 09:36 Mon 17 Jun     , Sascha Hauer wrote:
> Hi Christoph,
> 
> Some small comments, then we shoulf be good to go.
> 
> On Fri, Jun 14, 2013 at 05:11:02PM +0200, Christoph Fritz wrote:
> > This patch adds omap4 display controller support.
> > 
> > index 94e42c6..e70ddbd 100644
> > --- a/arch/arm/mach-omap/Makefile
> > +++ b/arch/arm/mach-omap/Makefile
> > @@ -28,6 +28,7 @@ obj-$(CONFIG_OMAP3_CLOCK_CONFIG) += omap3_clock.o
> >  pbl-$(CONFIG_OMAP3_CLOCK_CONFIG) += omap3_clock.o
> >  obj-$(CONFIG_OMAP_GPMC) += gpmc.o devices-gpmc-nand.o
> >  obj-$(CONFIG_SHELL_NONE) += xload.o
> > +obj-$(CONFIG_DRIVER_VIDEO_OMAP4) += omap4_fb.o
> 
> Please compile this in unconditionally. Otherwise board using this have
> to add a dependency on CONFIG_DRIVER_VIDEO_OMAP4 aswell.

if you have an inline for the fonction no need
as this will do the trick too

the mach-omap and the driver should be splittted and IIRC the omap fb is not
only for omap 4

I add Tomi to this patch from TI

> 
> > +struct device_d *omap4_add_display(void *pdata)
> 
> Let this function take a struct omap4fb_platform_data *. This makes it
> more clear how to call it.
and check the prototype by gcc
> 
> > +static void omap4fb_enable(struct fb_info *info)
> > +{
> > +	struct omap4fb_device *fbi =
> > +		container_of(info, struct omap4fb_device, info);
> 
> You could add a static inline to_omap4fb function. It's less error prone
> and the above would fit into a single line.
> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox