mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Teresa Gámez" <t.gamez@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] ARM: AM33xx: Add i2c support for AM33xx
Date: Fri, 21 Jun 2013 07:39:56 +0200	[thread overview]
Message-ID: <20130621053956.GX32299@pengutronix.de> (raw)
In-Reply-To: <1371732630-27966-3-git-send-email-t.gamez@phytec.de>

Hi Teresa,

On Thu, Jun 20, 2013 at 02:50:29PM +0200, Teresa Gámez wrote:
>  static void omap_i2c_unidle(struct omap_i2c_struct *i2c_omap)
>  {
> -	if (cpu_is_omap34xx()) {
> +	if (cpu_is_omap34xx() || cpu_is_am33xx()) {

Applied for now, but please consider converting this driver to use
id_table and a sane set of driver data. All these cpu_is_* do not scale
anymore for this driver.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-06-21  5:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20 12:50 [PATCH 0/3] I2C " Teresa Gámez
2013-06-20 12:50 ` [PATCH 1/3] i2c-omap: cleanup cpu_is functions Teresa Gámez
2013-06-20 12:50 ` [PATCH 2/3] ARM: AM33xx: Add i2c support for AM33xx Teresa Gámez
2013-06-21  5:39   ` Sascha Hauer [this message]
2013-06-20 12:50 ` [PATCH 3/3] ARM: OMAP: pcm051: Add i2c0 and at24 eeprom support Teresa Gámez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130621053956.GX32299@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=t.gamez@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox