From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Uqp6j-000836-Ru for barebox@lists.infradead.org; Sun, 23 Jun 2013 18:33:50 +0000 Date: Sun, 23 Jun 2013 20:33:24 +0200 From: Sascha Hauer Message-ID: <20130623183324.GJ32299@pengutronix.de> References: <1371827718-7928-1-git-send-email-sebastian.hesselbarth@gmail.com> <1371827718-7928-4-git-send-email-sebastian.hesselbarth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1371827718-7928-4-git-send-email-sebastian.hesselbarth@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/3] OF: base: add empty property value pointer To: Sebastian Hesselbarth Cc: barebox@lists.infradead.org On Fri, Jun 21, 2013 at 05:15:18PM +0200, Sebastian Hesselbarth wrote: > Since property values can be empty, we need property value pointer to > be non-NULL to distinguish those properties from non-existing properties. > This adds a static u32 to which empty properties set their value pointer. > Also, the value memory is only freed, if property length is not zero. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: barebox@lists.infradead.org > --- > drivers/of/base.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 7926d5d..a100a17 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -1501,6 +1501,8 @@ struct device_node *of_new_node(struct device_node *parent, const char *name) > return node; > } > > +static u32 empty_prop_value; > + > struct property *of_new_property(struct device_node *node, const char *name, > const void *data, int len) > { > @@ -1515,6 +1517,7 @@ struct property *of_new_property(struct device_node *node, const char *name, > goto bail_out; > > prop->length = len; > + prop->value = &empty_prop_value; This at least breaks of_set_property() and of_free(). Both unconditionally do a free(pp->value). Why do we need this anyway? We can always call of_find_property() to see if a property exists. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox