From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 08/11] ARM: i.MX6 realq7: prepare multiboard support
Date: Fri, 28 Jun 2013 09:40:40 +0200 [thread overview]
Message-ID: <20130628074040.GM27130@game.jcrosoft.org> (raw)
In-Reply-To: <20130627183217.GI516@pengutronix.de>
On 20:32 Thu 27 Jun , Sascha Hauer wrote:
> On Thu, Jun 27, 2013 at 09:03:26AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 10:00 Wed 26 Jun , Sascha Hauer wrote:
> > > return 0;
> > > }
> > > -core_initcall(realq7_console_init);
> > > +postcore_initcall(realq7_console_init);
> >
> > I really don't like those if (!of_mac......
>
> As discussed on IRQ I don't like it either...
IRQ ;)
>
> >
> > can we have a struct os is the kernel?
>
> ...but my experiments with a struct also were not very promising.
>
> I'm open for patches. For now I think the compatible matching is
> good enough, but it should be worked on before we have hundreds
> of initcalls like this.
as discuss on IRC I do prefer the struct like we have today on ARM Kernel
with something like this
struct machine {
const char *of_compatible;
u32 machine_id;
int (*pure)(void);
int (*mem)(void);
int (*console)(void);
int (*device)(void);
int (*late)(void);
};
I did it on at91 soc it's clean and speed the boot vs if xxx
I do agree this will requiere some work but this will have the advantage to not be only of related
so arch or board that are not OF can still use it
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-06-28 7:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 8:00 [PATCH] Multi board support Sascha Hauer
2013-06-26 8:00 ` [PATCH 01/11] ARM: i.MX: select SoC from board Sascha Hauer
2013-06-26 8:00 ` [PATCH 02/11] ARM: i.MX51 babbage: add board name to flash header file Sascha Hauer
2013-06-26 8:00 ` [PATCH 03/11] ARM: i.MX51 babbage: prepare for multiboard support Sascha Hauer
2013-06-26 8:00 ` [PATCH 04/11] ARM: i.MX51 babbage: Move over to multiboard Sascha Hauer
2013-06-26 8:00 ` [PATCH 05/11] ARM: i.MX53 loco: add board name to flash header file Sascha Hauer
2013-06-26 8:00 ` [PATCH 06/11] ARM: i.MX53 loco: prepare multiboard support Sascha Hauer
2013-06-26 8:00 ` [PATCH 07/11] ARM: i.MX53 loco: Move over to multiboard Sascha Hauer
2013-06-26 8:00 ` [PATCH 08/11] ARM: i.MX6 realq7: prepare multiboard support Sascha Hauer
2013-06-27 7:03 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-27 18:32 ` Sascha Hauer
2013-06-28 7:40 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-06-26 8:00 ` [PATCH 09/11] ARM: i.MX6 realq7: switch to multiboard Sascha Hauer
2013-06-26 8:00 ` [PATCH 10/11] ARM: i.MX51 efikasb: switch to multiboard support Sascha Hauer
2013-06-26 8:00 ` [PATCH 11/11] ARM: Add a imx_v7_defconfig Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130628074040.GM27130@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox