Re: [PATCH 7/9] OF: remove device and resource pointer from struct device_node

[Sascha Hauer <s.hauer@pengutronix.de>]

On Sat, Jun 29, 2013 at 04:28:57PM +0200, Sascha Hauer wrote:
> On Tue, Jun 25, 2013 at 11:20:45AM +0200, Sebastian Hesselbarth wrote:
> > diff --git a/drivers/of/gpio.c b/drivers/of/gpio.c
> > index 41e91ec..7f6d99c 100644
> > --- a/drivers/of/gpio.c
> > +++ b/drivers/of/gpio.c
> > @@ -10,6 +10,10 @@ int of_get_named_gpio(struct device_node *np,
> >  {
> >  	int ret;
> >  	struct of_phandle_args out_args;
> > +	struct device_d *dev = of_find_device_by_node(np);
> > +
> > +	if (!dev)
> > +		return -EINVAL;
> >  
> >  	ret = of_parse_phandle_with_args(np, propname, "#gpio-cells",
> >  					index, &out_args);
> > @@ -18,7 +22,7 @@ int of_get_named_gpio(struct device_node *np,
> >  		return -EINVAL;
> >  	}
> >  
> > -	ret = gpio_get_num(out_args.np->device, out_args.args[0]);
> > +	ret = gpio_get_num(dev, out_args.args[0]);
> 
> This doesn't work. What gpio_get_num needs is the device pointer from
> the gpio device, not from the device from the node we pass to this
> function. You would have to use of_find_device_by_node(out_args.np) here
> I guess.

Apart from this of_find_device_by_node() only works on platform_devices,
so this will break calling of_get_named_gpio on i2c gpio expanders.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox