[PATCH] Makefile: fix mixed implicit and normal rules

[PATCH] Makefile: fix mixed implicit and normal rules

[Alexander Aring]

Getting "Makefile:484: *** mixed implicit and normal rules.  Stop."
with make version "GNU Make 3.82".

This patch will fix this issue.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index d82e795..4b250dd 100644
--- a/Makefile
+++ b/Makefile
@@ -481,7 +481,7 @@ export KBUILD_BINARY ?= barebox.bin
 barebox-flash-image: $(KBUILD_IMAGE) FORCE
 	$(call if_changed,ln)
 
-images images/%.s: barebox.bin FORCE
+images/%.s: barebox.bin FORCE
 	$(Q)$(MAKE) $(build)=images $@
 
 ifdef CONFIG_PBL_MULTI_IMAGES
-- 
1.8.3.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] Makefile: fix mixed implicit and normal rules

[Lucas Stach]

Am Dienstag, den 02.07.2013, 14:24 +0200 schrieb Alexander Aring:
> Hi,
> 
> i am not a make expert but this is a common error with newer make
> versions.
> 
> But I think this solution isn't correct. It's better to split in two
> rules like:
> 
> images/%.s: barebox.bin FORCE
>         $(Q)$(MAKE) $(build)=images $@
> 
> images: barebox.bin FORCE
>         $(Q)$(MAKE) $(build)=images $@
> 
> Getting this information from:
> http://www.linuxquestions.org/questions/linux-software-2/error-mixed-implicit-and-normal-rules-while-trying-to-build-busybox-826795/
> 
> Regards
> Alex
> 
> 
This is already fixed. See message
1372457390-20162-1-git-send-email-dev@lynxeye.de
"[PATCH] Split Multimage Makefile rule in explicit and implicit parts"

Regards,
Lucas
-- 
Pengutronix e.K.                           | Lucas Stach                 |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] Makefile: fix mixed implicit and normal rules

[Alexander Aring]

Hi,

i am not a make expert but this is a common error with newer make
versions.

But I think this solution isn't correct. It's better to split in two
rules like:

images/%.s: barebox.bin FORCE
        $(Q)$(MAKE) $(build)=images $@

images: barebox.bin FORCE
        $(Q)$(MAKE) $(build)=images $@

Getting this information from:
http://www.linuxquestions.org/questions/linux-software-2/error-mixed-implicit-and-normal-rules-while-trying-to-build-busybox-826795/

Regards
Alex


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] Makefile: fix mixed implicit and normal rules

[Alexander Aring]

Hi,

On Tue, Jul 02, 2013 at 02:21:00PM +0200, Lucas Stach wrote:
> Am Dienstag, den 02.07.2013, 14:24 +0200 schrieb Alexander Aring:
> > Hi,
> > 
> > i am not a make expert but this is a common error with newer make
> > versions.
> > 
> > But I think this solution isn't correct. It's better to split in two
> > rules like:
> > 
> > images/%.s: barebox.bin FORCE
> >         $(Q)$(MAKE) $(build)=images $@
> > 
> > images: barebox.bin FORCE
> >         $(Q)$(MAKE) $(build)=images $@
> > 
> > Getting this information from:
> > http://www.linuxquestions.org/questions/linux-software-2/error-mixed-implicit-and-normal-rules-while-trying-to-build-busybox-826795/
> > 
> > Regards
> > Alex
> > 
> > 
> This is already fixed. See message
> 1372457390-20162-1-git-send-email-dev@lynxeye.de
> "[PATCH] Split Multimage Makefile rule in explicit and implicit parts"
> 

ah good to know. Thanks and sry for the noise. :-)

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox