* [PATCH] Makefile: fix mixed implicit and normal rules @ 2013-07-02 12:09 Alexander Aring 2013-07-02 12:24 ` Alexander Aring 0 siblings, 1 reply; 4+ messages in thread From: Alexander Aring @ 2013-07-02 12:09 UTC (permalink / raw) To: barebox Getting "Makefile:484: *** mixed implicit and normal rules. Stop." with make version "GNU Make 3.82". This patch will fix this issue. Signed-off-by: Alexander Aring <alex.aring@gmail.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d82e795..4b250dd 100644 --- a/Makefile +++ b/Makefile @@ -481,7 +481,7 @@ export KBUILD_BINARY ?= barebox.bin barebox-flash-image: $(KBUILD_IMAGE) FORCE $(call if_changed,ln) -images images/%.s: barebox.bin FORCE +images/%.s: barebox.bin FORCE $(Q)$(MAKE) $(build)=images $@ ifdef CONFIG_PBL_MULTI_IMAGES -- 1.8.3.2 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: fix mixed implicit and normal rules 2013-07-02 12:09 [PATCH] Makefile: fix mixed implicit and normal rules Alexander Aring @ 2013-07-02 12:24 ` Alexander Aring 2013-07-02 12:21 ` Lucas Stach 0 siblings, 1 reply; 4+ messages in thread From: Alexander Aring @ 2013-07-02 12:24 UTC (permalink / raw) To: barebox Hi, i am not a make expert but this is a common error with newer make versions. But I think this solution isn't correct. It's better to split in two rules like: images/%.s: barebox.bin FORCE $(Q)$(MAKE) $(build)=images $@ images: barebox.bin FORCE $(Q)$(MAKE) $(build)=images $@ Getting this information from: http://www.linuxquestions.org/questions/linux-software-2/error-mixed-implicit-and-normal-rules-while-trying-to-build-busybox-826795/ Regards Alex _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: fix mixed implicit and normal rules 2013-07-02 12:24 ` Alexander Aring @ 2013-07-02 12:21 ` Lucas Stach 2013-07-02 12:31 ` Alexander Aring 0 siblings, 1 reply; 4+ messages in thread From: Lucas Stach @ 2013-07-02 12:21 UTC (permalink / raw) To: Alexander Aring; +Cc: barebox Am Dienstag, den 02.07.2013, 14:24 +0200 schrieb Alexander Aring: > Hi, > > i am not a make expert but this is a common error with newer make > versions. > > But I think this solution isn't correct. It's better to split in two > rules like: > > images/%.s: barebox.bin FORCE > $(Q)$(MAKE) $(build)=images $@ > > images: barebox.bin FORCE > $(Q)$(MAKE) $(build)=images $@ > > Getting this information from: > http://www.linuxquestions.org/questions/linux-software-2/error-mixed-implicit-and-normal-rules-while-trying-to-build-busybox-826795/ > > Regards > Alex > > This is already fixed. See message 1372457390-20162-1-git-send-email-dev@lynxeye.de "[PATCH] Split Multimage Makefile rule in explicit and implicit parts" Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: fix mixed implicit and normal rules 2013-07-02 12:21 ` Lucas Stach @ 2013-07-02 12:31 ` Alexander Aring 0 siblings, 0 replies; 4+ messages in thread From: Alexander Aring @ 2013-07-02 12:31 UTC (permalink / raw) To: Lucas Stach; +Cc: barebox Hi, On Tue, Jul 02, 2013 at 02:21:00PM +0200, Lucas Stach wrote: > Am Dienstag, den 02.07.2013, 14:24 +0200 schrieb Alexander Aring: > > Hi, > > > > i am not a make expert but this is a common error with newer make > > versions. > > > > But I think this solution isn't correct. It's better to split in two > > rules like: > > > > images/%.s: barebox.bin FORCE > > $(Q)$(MAKE) $(build)=images $@ > > > > images: barebox.bin FORCE > > $(Q)$(MAKE) $(build)=images $@ > > > > Getting this information from: > > http://www.linuxquestions.org/questions/linux-software-2/error-mixed-implicit-and-normal-rules-while-trying-to-build-busybox-826795/ > > > > Regards > > Alex > > > > > This is already fixed. See message > 1372457390-20162-1-git-send-email-dev@lynxeye.de > "[PATCH] Split Multimage Makefile rule in explicit and implicit parts" > ah good to know. Thanks and sry for the noise. :-) _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-02 12:28 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-07-02 12:09 [PATCH] Makefile: fix mixed implicit and normal rules Alexander Aring 2013-07-02 12:24 ` Alexander Aring 2013-07-02 12:21 ` Lucas Stach 2013-07-02 12:31 ` Alexander Aring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox