Re: [PATCH 8/8] fs: Add ubifs support

[Alexander Aring <alex.aring@gmail.com>]

Hi,

On Tue, Aug 06, 2013 at 09:50:10PM +0200, Sascha Hauer wrote:
> Hi Alex,
> 
> On Tue, Aug 06, 2013 at 08:16:16PM +0200, Alexander Aring wrote:
> > Hi Sascha,
> > 
> > I take only a fast first look, it's a nice pretty huge patch :-)
> > 
> 
> Yes, it's huge. Unfortunately not only in source code size, but also in
> binary size...
> 
Yea, I meant it not in a negative way.

> > >  obj-$(CONFIG_FS_NFS)	+= nfs.o
> > > diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig
> > > new file mode 100644
> > > index 0000000..76612fd
> > > --- /dev/null
> > > +++ b/fs/ubifs/Kconfig
> > > @@ -0,0 +1,17 @@
> > > +menuconfig FS_UBIFS
> > > +	bool
> > 
> > select UBI here?
> > We use sometimes the ubi_read function.
> 
> Yes, right. I'll add a depends on CONFIG_MTD_UBI instead. selecting it
> is not good since UBI needs mtd which would introduce indirect
> dependencies.
> 
Oh yes, you already explained me the bad select and good depends on
thing a year ago.

> > > +	bool
> > > +	select LZO_DECOMPRESS
> > > +	prompt "LZO compression support"
> > > +
> > > +config FS_UBIFS_COMPRESSION_ZLIB
> > > +	bool
> > > +	select ZLIB
> > > +	prompt "ZLIB compression support"
> > > +
> > > +endif
> > 
> > Is this for a full compressed ubi volume? I know that in ubifs exists
> > some extended attributes to enable compression for a special file. How
> > barebox deal with that? I think barebox hasn't a support for xattr yet. :(
> 
> The compression in UBIFS comes from UBIFS, not from UBI. See mkfs.ubifs -h,
> you can specify different compression types.
> 
Yea, I meant here a support for reading a file which is compressed by
ubifs. Under Linux you can set extended attributed for the file(also for
compression). I don't know how barebox will dealing with that.

The question is what happens when I set the compression xattr for a file
under linux and then read it under barebox... Maybe I should try it and
then send patches if necessary :-).

- Alex

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox