mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] mci: sdhci: fix IRQSTAT_DMAE bit shift
@ 2013-08-24 22:20 Steffen Trumtrar
  2013-08-26  7:04 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Steffen Trumtrar @ 2013-08-24 22:20 UTC (permalink / raw)
  To: barebox; +Cc: Steffen Trumtrar

According to the SD Host Controller Specification Version 3.00, the ADMA error
status bit is on the wrong bit. Fix this.

While at it, add the missing standard error status bits.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 drivers/mci/sdhci.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mci/sdhci.h b/drivers/mci/sdhci.h
index b2d6779..2c8b6f5 100644
--- a/drivers/mci/sdhci.h
+++ b/drivers/mci/sdhci.h
@@ -37,8 +37,10 @@
 #define TRANSFER_MODE_BCEN	0x00000002
 #define TRANSFER_MODE_DMAEN	0x00000001
 
-#define IRQSTAT_DMAE		0x10000000
+#define IRQSTAT_TE		0x04000000
+#define IRQSTAT_DMAE		0x02000000
 #define IRQSTAT_AC12E		0x01000000
+#define IRQSTAT_CLE		0x00800000
 #define IRQSTAT_DEBE		0x00400000
 #define IRQSTAT_DCE		0x00200000
 #define IRQSTAT_DTOE		0x00100000
-- 
1.8.4.rc3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mci: sdhci: fix IRQSTAT_DMAE bit shift
  2013-08-24 22:20 [PATCH] mci: sdhci: fix IRQSTAT_DMAE bit shift Steffen Trumtrar
@ 2013-08-26  7:04 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2013-08-26  7:04 UTC (permalink / raw)
  To: Steffen Trumtrar; +Cc: barebox

On Sun, Aug 25, 2013 at 12:20:32AM +0200, Steffen Trumtrar wrote:
> According to the SD Host Controller Specification Version 3.00, the ADMA error
> status bit is on the wrong bit. Fix this.
> 
> While at it, add the missing standard error status bits.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>

Applied, thanks

Sascha

> ---
>  drivers/mci/sdhci.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mci/sdhci.h b/drivers/mci/sdhci.h
> index b2d6779..2c8b6f5 100644
> --- a/drivers/mci/sdhci.h
> +++ b/drivers/mci/sdhci.h
> @@ -37,8 +37,10 @@
>  #define TRANSFER_MODE_BCEN	0x00000002
>  #define TRANSFER_MODE_DMAEN	0x00000001
>  
> -#define IRQSTAT_DMAE		0x10000000
> +#define IRQSTAT_TE		0x04000000
> +#define IRQSTAT_DMAE		0x02000000
>  #define IRQSTAT_AC12E		0x01000000
> +#define IRQSTAT_CLE		0x00800000
>  #define IRQSTAT_DEBE		0x00400000
>  #define IRQSTAT_DCE		0x00200000
>  #define IRQSTAT_DTOE		0x00100000
> -- 
> 1.8.4.rc3
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-26  7:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-24 22:20 [PATCH] mci: sdhci: fix IRQSTAT_DMAE bit shift Steffen Trumtrar
2013-08-26  7:04 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox