Re: [RFC 1/8] ARM: add very initial support for Canon DIGIC chips

[Antony Pavlov <antonynpavlov@gmail.com>]

On Mon, 26 Aug 2013 21:46:48 -0400
Jason Cooper <jason@lakedaemon.net> wrote:

> On Tue, Aug 27, 2013 at 01:32:49AM +0200, Sebastian Hesselbarth wrote:
> > On 08/26/2013 09:47 PM, Jason Cooper wrote:
> > >On Mon, Aug 26, 2013 at 10:51:48PM +0400, Antony Pavlov wrote:
> > >>On Mon, 26 Aug 2013 09:20:18 -0400
> > >>Jason Cooper <jason@lakedaemon.net> wrote:
> > >>>On Mon, Aug 26, 2013 at 08:57:10AM +0400, Antony Pavlov wrote:
> > >>>>+/* Serial interface registers */
> > >>>>+#define DEBUG_LL_UART_TX         (DEBUG_LL_UART + 0x0)
> > >>>>+#define DEBUG_LL_UART_ST         (DEBUG_LL_UART + 0x14)
> > >>>>+ #define UART_ST_TX_RDY	2
> > >>>
> > >>>leading whitespace, and perhaps use BIT() here.
> > >>
> > >>The leading whitespace is put here intentionally to distinguish register address macros
> > >>and bit fields macros.
> > >
> > >CodingStyle doesn't spell it out explicitly, however:
> > >
> > >$ git grep -c '^[ \t]#define'
> > 
> > Jason,
> > 
> > you should have used
> > 
> > git grep -c '^#[ \t]define'
> > 
> > It is in fact quite common to distinguish address offset macros
> > and bit macros by adding a space, but between '#' and 'define'.

Thanks, Sebastian! You are right. I have just misplaced the space :)

> fair enough, I'll admit it's a personal bias. :-P I like everything
> lined up vertically so that differences from line to line stand out
> more.  But that's just me, and it's not my code, so I'll drop it.

Anyway I have a plan to rework these DEBUG_LL-related macros as they dublicate
the macros in the digic-serial driver :)

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox