From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] MIPS: qemu-malta: switch to devicetree
Date: Tue, 3 Sep 2013 13:21:56 +0200 [thread overview]
Message-ID: <20130903112156.GL19197@ns203013.ovh.net> (raw)
In-Reply-To: <20130903084123.60bf8561ef15b863013431e7@gmail.com>
On 08:41 Tue 03 Sep , Antony Pavlov wrote:
> On Tue, 3 Sep 2013 08:33:33 +0400
> Antony Pavlov <antonynpavlov@gmail.com> wrote:
>
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> > arch/mips/boards/qemu-malta/init.c | 31 ++-----------------------------
> > arch/mips/configs/qemu-malta_defconfig | 1 +
> > arch/mips/dts/qemu-malta.dts | 33 +++++++++++++++++++++++++++++++++
> > 3 files changed, 36 insertions(+), 29 deletions(-)
> >
> > diff --git a/arch/mips/boards/qemu-malta/init.c b/arch/mips/boards/qemu-malta/init.c
> > index ddc90dc..4d12495 100644
> > --- a/arch/mips/boards/qemu-malta/init.c
> > +++ b/arch/mips/boards/qemu-malta/init.c
> > @@ -17,39 +17,12 @@
> > */
> >
> > #include <common.h>
> > -#include <types.h>
> > -#include <driver.h>
> > #include <init.h>
> > -#include <ns16550.h>
> > -#include <mach/hardware.h>
> > -#include <partition.h>
> > -#include <sizes.h>
> >
> > -static int malta_devices_init(void)
> > +static int malta_core_init(void)
> > {
> > - add_cfi_flash_device(0, 0x1e000000, SZ_4M, 0);
> > -
> > - devfs_add_partition("nor0", 0x0, SZ_512K, DEVFS_PARTITION_FIXED, "self");
> > - devfs_add_partition("nor0", SZ_512K, SZ_64K, DEVFS_PARTITION_FIXED, "env0");
> > -
> > - return 0;
> > -}
> > -device_initcall(malta_devices_init);
> > -
> > -static struct NS16550_plat serial_plat = {
> > - .clock = 1843200, /* no matter for emulated port */
> > - .shift = 0,
> > -};
> > -
> > -static int malta_console_init(void)
> > -{
> > - barebox_set_model("qemu malta");
> > barebox_set_hostname("malta");
> >
>
> May be it is reasonable to add hostname support to dts?
>
> The lonely barebox_set_hostname() in the malta board code looks very pathetically :)
we could use the model propertie for this
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-09-03 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 4:33 Antony Pavlov
2013-09-03 4:41 ` Antony Pavlov
2013-09-03 11:21 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-09-04 6:30 ` Sascha Hauer
2013-09-04 7:59 ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-04 20:36 ` Sascha Hauer
2013-09-04 6:33 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903112156.GL19197@ns203013.ovh.net \
--to=plagnioj@jcrosoft.com \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox