From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Darren Garnier <dgarnier@reinrag.net>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/4] AT91: move have_intensity_bit into board setup
Date: Tue, 3 Sep 2013 13:39:42 +0200 [thread overview]
Message-ID: <20130903113942.GA22507@ns203013.ovh.net> (raw)
In-Reply-To: <7CB5E6E6-CC40-418F-ADB6-766DEC5D180A@reinrag.net>
On 22:22 Mon 02 Sep , Darren Garnier wrote:
> Signed-off-by: Darren Garnier <dgarnier@reinrag.net>
\why this is soc specific
Best Regards,
J.
> ---
> arch/arm/boards/at91sam9261ek/init.c | 2 ++
> arch/arm/mach-at91/at91sam9261_devices.c | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boards/at91sam9261ek/init.c b/arch/arm/boards/at91sam9261ek/init.c
> index 00fc745..b420a48 100644
> --- a/arch/arm/boards/at91sam9261ek/init.c
> +++ b/arch/arm/boards/at91sam9261ek/init.c
> @@ -223,6 +223,8 @@ static void ek_add_device_lcdc(void)
>
> if (machine_is_at91sam9g10ek())
> ek_lcdc_data.lcd_wiring_mode = ATMEL_LCDC_WIRING_RGB;
> + else
> + ek_lcdc_data.has_intensity_bit = true;
>
> at91_add_device_lcdc(&ek_lcdc_data);
> }
> diff --git a/arch/arm/mach-at91/at91sam9261_devices.c b/arch/arm/mach-at91/at91sam9261_devices.c
> index b522afb..ba52e56 100644
> --- a/arch/arm/mach-at91/at91sam9261_devices.c
> +++ b/arch/arm/mach-at91/at91sam9261_devices.c
> @@ -218,8 +218,6 @@ void __init at91_add_device_lcdc(struct atmel_lcdfb_platform_data *data)
> {
> BUG_ON(!data);
>
> - data->have_intensity_bit = true;
> -
> #if defined(CONFIG_FB_ATMEL_STN)
> at91_set_A_periph(AT91_PIN_PB0, 0); /* LCDVSYNC */
> at91_set_A_periph(AT91_PIN_PB1, 0); /* LCDHSYNC */
> --
> 1.8.3.1
>
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-09-03 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 2:22 Darren Garnier
2013-09-03 11:39 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-09-03 13:34 ` Darren Garnier
2013-09-03 15:31 ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-03 16:36 ` Darren Garnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903113942.GA22507@ns203013.ovh.net \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=dgarnier@reinrag.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox