mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Eric Bénard" <eric@eukrea.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] mxs_spi: fix compile error
Date: Tue, 10 Sep 2013 08:22:36 +0200	[thread overview]
Message-ID: <20130910062236.GX30088@pengutronix.de> (raw)
In-Reply-To: <1378756826-18061-1-git-send-email-eric@eukrea.com>

Hi Eric,

On Mon, Sep 09, 2013 at 10:00:25PM +0200, Eric Bénard wrote:
> this fix :
> drivers/spi/mxs_spi.c:29:22: fatal error: mach/mxs.h: No such file or directory
> and
> drivers/spi/mxs_spi.c: In function 'mxs_spi_setup':
> drivers/spi/mxs_spi.c:102:2: error: too few arguments to function 'stmp_reset_block'
> include/stmp-device.h:21:12: note: declared here
> 
> only compile tested ATM
> 
> Signed-off-by: Eric Bénard <eric@eukrea.com>

Applied both. Also I applied a patch which enables both drivers in the
imx28evk_defconfig. This should make sure this doesn't happen again
since I compile test all defconfigs.

Sascha

> ---
>  drivers/spi/mxs_spi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/mxs_spi.c b/drivers/spi/mxs_spi.c
> index 4e539bf..a803652 100644
> --- a/drivers/spi/mxs_spi.c
> +++ b/drivers/spi/mxs_spi.c
> @@ -26,7 +26,6 @@
>  #include <asm/mmu.h>
>  #include <mach/generic.h>
>  #include <mach/imx-regs.h>
> -#include <mach/mxs.h>
>  #include <mach/clock.h>
>  #include <mach/ssp.h>
>  
> @@ -100,7 +99,7 @@ static int mxs_spi_setup(struct spi_device *spi)
>  		return -EINVAL;
>  	}
>  
> -	stmp_reset_block(mxs->regs + HW_SSP_CTRL0);
> +	stmp_reset_block(mxs->regs + HW_SSP_CTRL0, 0);
>  
>  	val |= SSP_CTRL0_SSP_ASSERT_OUT(spi->chip_select);
>  	val |= SSP_CTRL0_BUS_WIDTH(0);
> -- 
> 1.8.3.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2013-09-10  6:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-09 20:00 Eric Bénard
2013-09-09 20:00 ` [PATCH 2/2] serial_auart: " Eric Bénard
2013-09-10  6:22 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130910062236.GX30088@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=eric@eukrea.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox