From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] smc91111: add phy flags support
Date: Fri, 20 Sep 2013 09:00:37 +0200 [thread overview]
Message-ID: <20130920070036.GB30088@pengutronix.de> (raw)
In-Reply-To: <1379569815-14033-1-git-send-email-plagnioj@jcrosoft.com>
On Thu, Sep 19, 2013 at 07:50:14AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> drivers/net/smc91111.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/smc91111.c b/drivers/net/smc91111.c
> index 48183dd..8c7a343 100644
> --- a/drivers/net/smc91111.c
> +++ b/drivers/net/smc91111.c
> @@ -886,6 +886,7 @@ static void smc91c111_enable(struct eth_device *edev)
> static int smc91c111_eth_open(struct eth_device *edev)
> {
> struct smc91c111_priv *priv = (struct smc91c111_priv *)edev->priv;
> + int ret;
>
> /* Configure the Receive/Phy Control register */
> SMC_SELECT_BANK(priv, 0);
> @@ -893,8 +894,27 @@ static int smc91c111_eth_open(struct eth_device *edev)
>
> smc91c111_enable(edev);
>
> - return phy_device_connect(edev, &priv->miibus, 0, NULL,
> + ret = phy_device_connect(edev, &priv->miibus, 0, NULL,
> 0, PHY_INTERFACE_MODE_NA);
> +
> + if (ret)
> + return ret;
> +
> + if (edev->phydev->phy_id == 0x00000000) {
> + struct phy_device *dev = edev->phydev;
Is this the correct patch? It's the same patch you sent earlier with
another commit message as a qemu fixup.
Sascha
> +
> + dev->speed = SPEED_100;
> + dev->duplex = DUPLEX_FULL;
> + dev->autoneg = !AUTONEG_ENABLE;
> + dev->force = 1;
> + dev->link = 1;
> +
> + dev_info(edev->parent, "phy with id 0x%08x detected this might be qemu\n",
> + dev->phy_id);
> + dev_info(edev->parent, "force link at 100Mpbs\n");
> + }
> +
> + return 0;
> }
>
> static int smc91c111_eth_send(struct eth_device *edev, void *packet,
> --
> 1.8.4.rc1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-09-20 7:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 5:50 Jean-Christophe PLAGNIOL-VILLARD
2013-09-19 5:50 ` [PATCH 2/2] versatilepb: force net a 100Mpps Jean-Christophe PLAGNIOL-VILLARD
2013-09-19 11:21 ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-20 7:01 ` Sascha Hauer
2013-09-21 15:42 ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-20 7:00 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920070036.GB30088@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox