From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] misc: add bootcount framework
Date: Mon, 23 Sep 2013 09:33:46 +0200 [thread overview]
Message-ID: <20130923073346.GT30088@pengutronix.de> (raw)
In-Reply-To: <1379745967-4575-1-git-send-email-plagnioj@jcrosoft.com>
On Sat, Sep 21, 2013 at 08:46:04AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> The bootcount is always how many time the system start.
> To determine since when, this will depend on the driver implementation
> and your hardware feature.
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> drivers/misc/Kconfig | 2 ++
> drivers/misc/Makefile | 1 +
> drivers/misc/bootcount/Kconfig | 12 +++++++++
> drivers/misc/bootcount/Makefile | 1 +
> drivers/misc/bootcount/core.c | 54 +++++++++++++++++++++++++++++++++++++++++
> include/bootcount.h | 31 +++++++++++++++++++++++
> 6 files changed, 101 insertions(+)
> create mode 100644 drivers/misc/bootcount/Kconfig
> create mode 100644 drivers/misc/bootcount/Makefile
> create mode 100644 drivers/misc/bootcount/core.c
> create mode 100644 include/bootcount.h
This is getting worse. I don't get it why we need a 'framework' to
abstract a single variable. With this series we now have three
layers: a bootcount framework, a midlayer driver and a somfy specific
driver.
Can we please just do something like:
common/bootcount.c:
static int bootcount;
/*
* Call this with your actual boot count, already increased by one
* for the current boot.
*/
int bootcount_set(int count)
{
if (bootcount) {
pr_err("Bootcount already set\n");
return -EINVAL;
}
bootcount = count;
return 0;
}
static int bootcount_init(void)
{
globalvar_add_simple_int_ro("bootcount", &bootcount, "%d");
return 0;
}
late_initcall(bootcount_init);
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-09-23 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 6:45 [PATCH 0/4 v2] introduce bootcount support Jean-Christophe PLAGNIOL-VILLARD
2013-09-21 6:46 ` [PATCH 1/4] misc: add bootcount framework Jean-Christophe PLAGNIOL-VILLARD
2013-09-21 6:46 ` [PATCH 2/4] bootcount: add simple register support Jean-Christophe PLAGNIOL-VILLARD
2013-09-21 6:46 ` [PATCH 3/4] bootcount: add somfy bootcount support Jean-Christophe PLAGNIOL-VILLARD
2013-09-21 6:46 ` [PATCH 4/4] animeo_ip: add " Jean-Christophe PLAGNIOL-VILLARD
2013-09-23 7:33 ` Sascha Hauer [this message]
2013-09-23 8:05 ` [PATCH 1/4] misc: add bootcount framework Jean-Christophe PLAGNIOL-VILLARD
2013-09-23 8:52 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923073346.GT30088@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox