Re: [PATCH 1/2 v2] filetype: add Binary PacKage BPK type - Jean-Christophe PLAGNIOL-VILLARD

From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, Fargier Sylvain <sylvain.fargier@somfy.com>
Subject: Re: [PATCH 1/2 v2] filetype: add Binary PacKage BPK type
Date: Tue, 24 Sep 2013 11:23:23 +0200	[thread overview]
Message-ID: <20130924092323.GI31585@ns203013.ovh.net> (raw)
In-Reply-To: <20130924073437.GB30088@pengutronix.de>

On 09:34 Tue 24 Sep     , Sascha Hauer wrote:
> On Sat, Sep 21, 2013 at 04:54:15PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > Signed-off-by: Fargier Sylvain <sylvain.fargier@somfy.com>
> > ---
> >  common/filetype.c  | 3 +++
> >  include/filetype.h | 1 +
> >  2 files changed, 4 insertions(+)
> > 
> > diff --git a/common/filetype.c b/common/filetype.c
> > index 59ea25a..ef4452d 100644
> > --- a/common/filetype.c
> > +++ b/common/filetype.c
> > @@ -51,6 +51,7 @@ static const struct filetype_str filetype_str[] = {
> >  	[filetype_png] = { "PNG image", "png" },
> >  	[filetype_ext] = { "ext filesystem", "ext" },
> >  	[filetype_gpt] = { "GUID Partition Table", "gpt" },
> > +	[filetype_bpk] = { "Binary PacKage", "bpk" },
> 
> Can we have "Somfy Binary PacKage" here? As this file format is rather
> exoctic I want to make sure we still know what this is in a few years.
> Was the CamelCase 'PacKage' intended?
We drop the Somfy to make it more generic and everyone can use it
as everything is published

The CamelCase is historical we just kepp it

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox