mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/8] console: introduce startup and shutdown
Date: Fri, 27 Sep 2013 11:03:57 +0200	[thread overview]
Message-ID: <20130927090357.GF32444@ns203013.ovh.net> (raw)
In-Reply-To: <20130927085509.GQ30088@pengutronix.de>

On 10:55 Fri 27 Sep     , Sascha Hauer wrote:
> On Fri, Sep 27, 2013 at 09:14:14AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > so enable the uart only if used
> > so linux can detect the right one enable if it want
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> >  common/console.c        |  6 ++++++
> >  common/console_common.c | 36 ++++++++++++++++++++++++++++++++++++
> >  common/console_simple.c |  3 +++
> >  include/console.h       |  4 ++++
> >  4 files changed, 49 insertions(+)
> > 
> > diff --git a/common/console.c b/common/console.c
> > index 56bc864..00fd2cf 100644
> > --- a/common/console.c
> > +++ b/common/console.c
> > @@ -83,8 +83,14 @@ static int console_std_set(struct device_d *dev, struct param_d *param,
> >  
> >  	if (flag && !cdev->f_active) {
> >  		/* The device is being activated, set its baudrate */
> > +		if (cdev->startup)
> > +			cdev->startup(cdev);
> >  		if (cdev->setbrg)
> >  			cdev->setbrg(cdev, cdev->baudrate);
> > +	} else if (!flag && cdev->f_active) {
> > +		/* The device is being desactivated, shutdown it */
> 
> 		/* The device is being deactivated, shut it down */
> 
> > +
> > +int console_open(struct console_device *cdev)
> > +{
> > +	int ret;
> > +
> > +	if (cdev->f_active)
> > +		return 0;
> > +
> > +	if (cdev->startup) {
> > +		ret = cdev->startup(cdev);
> > +		if (ret)
> > +			return ret;
> > +	}
> > +
> > +	if (cdev->setbrg) {
> > +		cdev->baudrate = CONFIG_BAUDRATE;
> 
> I believe cdev->baudrate should be set only once during initialization.
> When I deactivate a console and activate it again I don't expect the
> baudrate to be changed to it's default value.

maybe but if the device is not a console but rs485 you never set the baudrate
today same if a device is never active

as example use a non active device for loadxy

so I'm think that the console_open is more like man 2 open + ioctl to use a
cdev

later we will switch to open + ioctl API
for now on I prefer to just fix the big issues and prepare to switch easly

Best Regards,
J.
> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-09-27  9:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27  7:12 [PATCH 0/8] more serial cleanup Jean-Christophe PLAGNIOL-VILLARD
2013-09-27  7:14 ` [PATCH 1/8] console_simple: fix: set f_active Jean-Christophe PLAGNIOL-VILLARD
2013-09-27  7:14   ` [PATCH 2/8] console: factorise function to get the first enabled console Jean-Christophe PLAGNIOL-VILLARD
2013-09-27  8:44     ` Sascha Hauer
2013-09-27  7:14   ` [PATCH 3/8] console: factorise function to get the console by name Jean-Christophe PLAGNIOL-VILLARD
2013-09-27  8:50     ` Sascha Hauer
2013-09-27  8:58       ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-27  9:05         ` Sascha Hauer
2013-09-27  9:07           ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-27  7:14   ` [PATCH 4/8] console: introduce startup and shutdown Jean-Christophe PLAGNIOL-VILLARD
2013-09-27  8:55     ` Sascha Hauer
2013-09-27  9:03       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-09-27  9:09         ` Sascha Hauer
2013-09-27  9:20           ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-27  7:14   ` [PATCH 5/8] loadbxy: use console_open/close Jean-Christophe PLAGNIOL-VILLARD
2013-09-27  7:14   ` [PATCH 6/8] animeo_ip: update to use console_open/close for rs485 crossed detection Jean-Christophe PLAGNIOL-VILLARD
2013-09-27  7:14   ` [PATCH 7/8] serial: amba-pl011: add start and shutdown support Jean-Christophe PLAGNIOL-VILLARD
2013-09-27  7:14   ` [PATCH 8/8] serial: atmel: " Jean-Christophe PLAGNIOL-VILLARD
2013-09-27  9:07 ` [PATCH 9/9] console: console_get_by_name pass flags Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130927090357.GF32444@ns203013.ovh.net \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox