From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VPU3E-0004Ad-L4 for barebox@lists.infradead.org; Fri, 27 Sep 2013 09:09:29 +0000 Date: Fri, 27 Sep 2013 11:09:06 +0200 From: Sascha Hauer Message-ID: <20130927090906.GT30088@pengutronix.de> References: <20130927071255.GB32444@ns203013.ovh.net> <1380266058-18501-1-git-send-email-plagnioj@jcrosoft.com> <1380266058-18501-4-git-send-email-plagnioj@jcrosoft.com> <20130927085509.GQ30088@pengutronix.de> <20130927090357.GF32444@ns203013.ovh.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130927090357.GF32444@ns203013.ovh.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 4/8] console: introduce startup and shutdown To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org On Fri, Sep 27, 2013 at 11:03:57AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 10:55 Fri 27 Sep , Sascha Hauer wrote: > > On Fri, Sep 27, 2013 at 09:14:14AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > so enable the uart only if used > > > so linux can detect the right one enable if it want > > > +{ > > > + int ret; > > > + > > > + if (cdev->f_active) > > > + return 0; > > > + > > > + if (cdev->startup) { > > > + ret = cdev->startup(cdev); > > > + if (ret) > > > + return ret; > > > + } > > > + > > > + if (cdev->setbrg) { > > > + cdev->baudrate = CONFIG_BAUDRATE; > > > > I believe cdev->baudrate should be set only once during initialization. > > When I deactivate a console and activate it again I don't expect the > > baudrate to be changed to it's default value. > > maybe but if the device is not a console but rs485 you never set the baudrate > today same if a device is never active > > as example use a non active device for loadxy > > so I'm think that the console_open is more like man 2 open + ioctl to use a > cdev Put a cdev->baudrate = CONFIG_BAUDRATE in console_register() instead of console_open. This doesn't affect RS485 at all but fixes the behaviour i moaned about. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox