From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mci: omap: Fix default value of mci.f_max
Date: Fri, 27 Sep 2013 15:29:40 +0200 [thread overview]
Message-ID: <20130927132940.GH32444@ns203013.ovh.net> (raw)
In-Reply-To: <20130927121920.GA526@omega>
On 14:19 Fri 27 Sep , Alexander Aring wrote:
> Hi,
>
> On Fri, Sep 27, 2013 at 02:13:00PM +0200, Teresa Gámez wrote:
> > Set default value of mci.f_max even when no pdata
> > is available.
> >
> > Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> > ---
> > drivers/mci/omap_hsmmc.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mci/omap_hsmmc.c b/drivers/mci/omap_hsmmc.c
> > index a2cd3fe..f63697f 100644
> > --- a/drivers/mci/omap_hsmmc.c
> > +++ b/drivers/mci/omap_hsmmc.c
> > @@ -614,11 +614,11 @@ static int omap_mmc_probe(struct device_d *dev)
> > if (pdata) {
> > if (pdata->f_max)
> > hsmmc->mci.f_max = pdata->f_max;
> > - else
> > - hsmmc->mci.f_max = 52000000;
>
> I think this should stay there for the case if f_max is zero.
> So somebody sets a pdata with devname and no f_max value.
>
>
> Maybe you should add a default devname if no pdata is given.
no there is a default devname disk.%d
>
> - Alex
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-09-27 13:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 12:13 Teresa Gámez
2013-09-27 12:19 ` Alexander Aring
2013-09-27 13:29 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-09-27 13:36 ` Alexander Aring
2013-09-27 13:38 ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-27 13:40 ` Alexander Aring
2013-09-27 13:45 ` Alexander Aring
2013-09-27 13:52 ` Teresa Gamez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927132940.GH32444@ns203013.ovh.net \
--to=plagnioj@jcrosoft.com \
--cc=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox