mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/6] ARM: mx23-evk: Fix result checking of devfs_add_partition
Date: Wed, 2 Oct 2013 10:29:25 +0200	[thread overview]
Message-ID: <20131002082925.GI30088@pengutronix.de> (raw)
In-Reply-To: <20131001074947.GI2548@pengutronix.de>

On Tue, Oct 01, 2013 at 09:49:47AM +0200, Uwe Kleine-König wrote:
> Hello Sascha,
> 
> On Tue, Oct 01, 2013 at 08:22:05AM +0200, Sascha Hauer wrote:
> > +	if (IS_ERR(cdev))
> > +		return PTR_ERR(cdev);
> > +	return 0;
> In Linux you can use
> 
> 	return PTR_ERR_OR_ZERO(cdev)
> 
> instead. Didn't check if barebox already has that.

I wasn't aware this exists. barebox currently doesn't have this, but it
would be nice to introduce it.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-10-02  8:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01  6:22 Compiler warning fixes Sascha Hauer
2013-10-01  6:22 ` [PATCH 1/6] ARM: edb93xx: Add missing include Sascha Hauer
2013-10-01  6:22 ` [PATCH 2/6] ARM: friendlyarm-tiny210: remove unused variable Sascha Hauer
2013-10-01  6:22 ` [PATCH 3/6] ARM: mx23-evk: Fix result checking of devfs_add_partition Sascha Hauer
2013-10-01  7:49   ` Uwe Kleine-König
2013-10-02  8:29     ` Sascha Hauer [this message]
2013-10-01  6:22 ` [PATCH 4/6] ARM: Ka-Ro TX28: " Sascha Hauer
2013-10-01  6:22 ` [PATCH 5/6] ARM: vexpress: Fix compiler warning Sascha Hauer
2013-10-01 13:22   ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-02  8:27     ` Sascha Hauer
2013-10-01  6:22 ` [PATCH 6/6] mips: bcm47xx: " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131002082925.GI30088@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox