From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Jan Luebbe <jlu@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [SPAM] [PATCH] common: fix possible build problem without password support
Date: Mon, 14 Oct 2013 17:46:19 +0200 [thread overview]
Message-ID: <20131014154619.GV32444@ns203013.ovh.net> (raw)
In-Reply-To: <1381765165-22365-1-git-send-email-jlu@pengutronix.de>
On 17:39 Mon 14 Oct , Jan Luebbe wrote:
> In the case where CONFIG_PASSWORD is off, CONFIG_PASSWORD_DEFAULT is
> undefined. As undefined is not "", this causes make to call find -type f.
> If there is a filename containing a :, make will complain about having
> "multiple target patterns"
>
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
> ---
> common/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/common/Makefile b/common/Makefile
> index 75d924e..6f6e360 100644
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -116,6 +116,7 @@ $(obj)/barebox_default_env.h: $(obj)/barebox_default_env$(barebox_default_env_co
> $(call if_changed,env_h)
>
> quiet_cmd_pwd_h = PWDH $@
> +ifdef CONFIG_PASSWORD
??
so if no password then it do
cmd_pwd_h = echo "const char default_passwd[] = \"\";" > $@
that's all
so we do not need to check CONFIG_PASSSORD
> ifneq ($(CONFIG_PASSWORD_DEFAULT),"")
> PASSWD_FILE := $(shell cd $(srctree); find $(CONFIG_PASSWORD_DEFAULT) -type f)
> cmd_pwd_h = echo -n "const char default_passwd[] = \"" > $@; \
> @@ -134,6 +135,7 @@ endif
> targets += include/generated/passwd.h
>
> $(obj)/password.o: include/generated/passwd.h
> +endif
>
> # dependencies on generated files need to be listed explicitly
> $(obj)/version.o: include/generated/compile.h
> --
> 1.8.4.rc3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-10-14 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 15:39 Jan Luebbe
2013-10-14 15:46 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-10-14 16:01 ` [SPAM] " Jan Lübbe
2013-10-14 17:06 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-15 6:37 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014154619.GV32444@ns203013.ovh.net \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=jlu@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox