From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Jan L??bbe <jlu@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [SPAM] [PATCH] common: fix possible build problem without password support
Date: Mon, 14 Oct 2013 19:06:27 +0200 [thread overview]
Message-ID: <20131014170627.GW32444@ns203013.ovh.net> (raw)
In-Reply-To: <1381766493.11504.83.camel@coredoba.hi.pengutronix.de>
On 18:01 Mon 14 Oct , Jan L??bbe wrote:
> Hi,
>
> On Mon, 2013-10-14 at 17:46 +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > quiet_cmd_pwd_h = PWDH $@
> > > +ifdef CONFIG_PASSWORD
> >
> > ??
> >
> > so if no password then it do
> >
> > cmd_pwd_h = echo "const char default_passwd[] = \"\";" > $@
> >
> > that's all
> >
> > so we do not need to check CONFIG_PASSSORD
>
> No. Try adding 'set -x;' to the shell call and building without
> CONFIG_PASSWORD. In that case CONFIG_PASSWORD_DEFAULT is not set.
> An unset Kconfig variable is not equal to "".
>
> > > ifneq ($(CONFIG_PASSWORD_DEFAULT),"")
> > > PASSWD_FILE := $(shell cd $(srctree); find $(CONFIG_PASSWORD_DEFAULT) -type f)
>
> Try with:
> PASSWD_FILE := $(shell set -x; cd $(srctree); echo `find $(CONFIG_PASSWORD_DEFAULT) -type f`)
with set -x I've the issue ok
Best Regards,
J.
>
> > > cmd_pwd_h = echo -n "const char default_passwd[] = \"" > $@; \
> > > @@ -134,6 +135,7 @@ endif
> > > targets += include/generated/passwd.h
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-10-14 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 15:39 Jan Luebbe
2013-10-14 15:46 ` [SPAM] " Jean-Christophe PLAGNIOL-VILLARD
2013-10-14 16:01 ` Jan Lübbe
2013-10-14 17:06 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-10-15 6:37 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014170627.GW32444@ns203013.ovh.net \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=jlu@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox