From: Andre Heider <a.heider@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: rpi: add SD card environment support
Date: Tue, 15 Oct 2013 18:22:09 +0200 [thread overview]
Message-ID: <20131015162209.GA41640@gmail.com> (raw)
In-Reply-To: <20131015125312.GJ30088@pengutronix.de>
On Tue, Oct 15, 2013 at 02:53:12PM +0200, Sascha Hauer wrote:
> On Tue, Oct 15, 2013 at 01:54:50PM +0200, Andre Heider wrote:
> > Hi,
> >
> > > +static int rpi_env_init(void)
> > > +{
> > > + struct stat s;
> > > + const char *diskdev = "/dev/disk0.0";
> > > + int ret;
> > > +
> > > + device_detect_by_name("mci0");
> > > +
> > > + ret = stat(diskdev, &s);
> > > + if (ret) {
> > > + printf("no %s. using default env\n", diskdev);
> > > + return 0;
> > > + }
> > > +
> > > + mkdir("/boot", 0666);
> > > + ret = mount(diskdev, "fat", "/boot");
> > > + if (ret) {
> > > + printf("failed to mount %s\n", diskdev);
> > > + return 0;
> > > + }
> > > +
> > > + default_environment_path = "/boot/barebox.env";
> > > +
> > > + return 0;
> > > +}
> >
> > I was solving the same thing just yesterday ;)
> >
> > What I did was to create a env/init/automount script, what's the advantage of this approach?
>
> This approach also sets default_environment_path to /boot/barebox.env so
> that loadenv/saveenv works and barebox comes up with the saved
> environment.
>
> You could probably do similar with scripts doing something like:
>
> automount -d /boot "detect mci0 && mount /dev/disk0.0 /boot"
> loadenv -s /boot/barebox.env /env
> /env/bin/init
>
> However, I made the experience that in scripts proper error checking is
> hard to archieve and therefore often skipped. Also with C Code a single
> git commitish makes the system behaviour clear. When instead scripts are
> used which might have been modified by a user, or which might come from
> an older barebox version the situation gets much more complex.
>
> I generally try to reduce the usage (or better: necessity) of scripts.
> They pretend a high level of flexibility but this comes at the cost of
> reduced consistency across different boards (or even different instances
> of the same board)
>
Alright, thanks!
Regards,
Andre
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-10-15 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 10:50 Sascha Hauer
2013-10-15 11:36 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-16 7:44 ` Sascha Hauer
2013-10-15 11:54 ` Andre Heider
2013-10-15 12:53 ` Sascha Hauer
2013-10-15 16:22 ` Andre Heider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015162209.GA41640@gmail.com \
--to=a.heider@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox