From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VWLfm-0000PX-K5 for barebox@lists.infradead.org; Wed, 16 Oct 2013 07:37:39 +0000 Date: Wed, 16 Oct 2013 09:37:16 +0200 From: Sascha Hauer Message-ID: <20131016073716.GN30088@pengutronix.de> References: <1381858703-27993-2-git-send-email-a.heider@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1381858703-27993-2-git-send-email-a.heider@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] ARM: rpi: fix reading of the EMMC clock for CONFIG_MMU To: Andre Heider Cc: barebox@lists.infradead.org On Tue, Oct 15, 2013 at 07:38:23PM +0200, Andre Heider wrote: > Add explicit flushing to prevent the 50MHz fallback. Oops, I saw the message but didn't notice I introduced it. The bcm2835_mci_get_emmc_clock() seems to use some mailbox system to get the clock (from the graphics core?). We should probably convert this into some generic code to access these bcm2835 mailboxes. Maybe U-Boot or the kernel already provide code for it. Anyway, applied this patch for now. Sascha > > Signed-off-by: Andre Heider > --- > drivers/mci/mci-bcm2835.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/mci/mci-bcm2835.c b/drivers/mci/mci-bcm2835.c > index a0c364d..2ffdeec 100644 > --- a/drivers/mci/mci-bcm2835.c > +++ b/drivers/mci/mci-bcm2835.c > @@ -28,6 +28,7 @@ > * Author: Wilhelm Lundgren > */ > > +#include > #include > #include > #include > @@ -471,7 +472,7 @@ int bcm2835_mci_reset(struct mci_host *mci, struct device_d *mci_dev) > static u32 bcm2835_mci_get_emmc_clock(struct msg_get_clock_rate *clk_data) > { > u32 val; > - struct bcm2835_mbox_regs *regs = > + struct bcm2835_mbox_regs __iomem *regs = > (struct bcm2835_mbox_regs *) BCM2835_MBOX_PHYSADDR; > > /*Read out old msg*/ > @@ -489,6 +490,7 @@ static u32 bcm2835_mci_get_emmc_clock(struct msg_get_clock_rate *clk_data) > break; > } > val = BCM2835_MBOX_PROP_CHAN + ((u32) &clk_data->hdr); > + dma_flush_range((u32)clk_data, (u32)clk_data + sizeof(*clk_data)); > writel(val, ®s->write); > > while (true) { > @@ -504,6 +506,9 @@ static u32 bcm2835_mci_get_emmc_clock(struct msg_get_clock_rate *clk_data) > if ((val & 0x0F) == BCM2835_MBOX_PROP_CHAN) > break; > } > + > + dma_inv_range((u32)clk_data, (u32)clk_data + sizeof(*clk_data)); > + > if ((val & ~0x0F) == ((u32) &clk_data->hdr)) > if (clk_data->get_clock_rate.tag_hdr.val_len > & BCM2835_MBOX_TAG_VAL_LEN_RESPONSE) > -- > 1.8.3.2 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox