From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 12.mo3.mail-out.ovh.net ([188.165.41.191] helo=mo3.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VX9n4-0002Pb-Vg for barebox@lists.infradead.org; Fri, 18 Oct 2013 13:08:32 +0000 Received: from mail247.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo3.mail-out.ovh.net (Postfix) with SMTP id B3495FF980B for ; Fri, 18 Oct 2013 14:58:42 +0200 (CEST) Date: Fri, 18 Oct 2013 15:00:09 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20131018130009.GY32444@ns203013.ovh.net> References: <1382090851-7993-1-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1382090851-7993-1-git-send-email-s.hauer@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] USB: storage: register disks as usbdiskx To: Sascha Hauer Cc: barebox@lists.infradead.org On 12:07 Fri 18 Oct , Sascha Hauer wrote: > To better identify them as USB storage devices. Also make the > info message look nicer. we brake the env support I think it's time to add symblink support to devfs so we can have disk%x and a usbdisk%x so we do not brake it Best Regards, J. > > Signed-off-by: Sascha Hauer > --- > drivers/usb/storage/usb.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c > index e4b08b9..fbf458f 100644 > --- a/drivers/usb/storage/usb.c > +++ b/drivers/usb/storage/usb.c > @@ -392,12 +392,11 @@ static int usb_stor_add_blkdev(struct us_data *us, struct device_d *dev, > if (result < 0) > goto BadDevice; > > - result = cdev_find_free_index("disk"); > + result = cdev_find_free_index("usbdisk"); > if (result == -1) > pr_err("Cannot find a free number for the disk node\n"); > - pr_info("Using index %d for the new disk\n", result); > > - pblk_dev->blk.cdev.name = asprintf("disk%d", result); > + pblk_dev->blk.cdev.name = asprintf("usbdisk%d", result); > pblk_dev->blk.blockbits = SECTOR_SHIFT; > > result = blockdevice_register(&pblk_dev->blk); > @@ -406,6 +405,8 @@ static int usb_stor_add_blkdev(struct us_data *us, struct device_d *dev, > goto BadDevice; > } > > + dev_info(dev, "registered /dev/%s\n", pblk_dev->blk.cdev.name); > + > /* create partitions on demand */ > result = parse_partition_table(&pblk_dev->blk); > if (result != 0) > -- > 1.8.4.rc3 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox