From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Eric Bénard" <eric@eukrea.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] bcb: fix compilation
Date: Mon, 28 Oct 2013 14:20:29 +0100 [thread overview]
Message-ID: <20131028132029.GM30088@pengutronix.de> (raw)
In-Reply-To: <1382621212-28611-1-git-send-email-eric@eukrea.com>
On Thu, Oct 24, 2013 at 03:26:52PM +0200, Eric Bénard wrote:
> this fix :
> arch/arm/mach-mxs/bcb.c:268: error: too few arguments to function 'chip->ecc.read_page_raw'
> arch/arm/mach-mxs/bcb.c:309: error: too few arguments to function 'chip->write_page'
>
> caution : this is NOT runtime tested.
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
Applied, thanks
Sascha
> ---
> arch/arm/mach-mxs/bcb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mxs/bcb.c b/arch/arm/mach-mxs/bcb.c
> index af51d24..b5d793e 100644
> --- a/arch/arm/mach-mxs/bcb.c
> +++ b/arch/arm/mach-mxs/bcb.c
> @@ -265,7 +265,7 @@ static int find_fcb(struct mtd_info *mtd, void *ref, int page)
>
> chip->select_chip(mtd, 0);
> chip->cmdfunc(mtd, NAND_CMD_READ0, 0x00, page);
> - ret = chip->ecc.read_page_raw(mtd, chip, buf);
> + ret = chip->ecc.read_page_raw(mtd, chip, buf, 1, page);
> if (ret) {
> printf("Failed to read FCB from page %u: %d\n", page, ret);
> return ret;
> @@ -306,7 +306,7 @@ static int write_fcb(struct mtd_info *mtd, void *buf, int block)
>
> printf("Writing FCB to block %08x\n", block);
> chip->select_chip(mtd, 0);
> - ret = chip->write_page(mtd, chip, buf, page, 0, 1);
> + ret = chip->write_page(mtd, chip, 0, mtd->erasesize, buf, 1, page, 0, 1);
> if (ret) {
> printf("Failed to write FCB to block %08x: %d\n", block, ret);
> }
> --
> 1.8.3.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-10-28 13:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 13:26 Eric Bénard
2013-10-28 13:20 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028132029.GM30088@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eric@eukrea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox