From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VcLLO-0000Q0-6Q for barebox@lists.infradead.org; Fri, 01 Nov 2013 20:29:23 +0000 Date: Fri, 1 Nov 2013 21:28:59 +0100 From: Sascha Hauer Message-ID: <20131101202859.GM24559@pengutronix.de> References: <1383128571-8250-1-git-send-email-renaud.barbier@ge.com> <1383128571-8250-5-git-send-email-renaud.barbier@ge.com> <20131030113452.GG26639@ns203013.ovh.net> <20131031074833.GI24559@pengutronix.de> <5272B934.7080508@ge.com> <20131101115852.GL24559@pengutronix.de> <5273A50B.1010700@ge.com> <5273A65E.6090300@ge.com> <5273C2CE.3010602@ge.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5273C2CE.3010602@ge.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 4/5] ppc: DA923RC: add board support To: Renaud Barbier Cc: barebox@lists.infradead.org On Fri, Nov 01, 2013 at 03:03:42PM +0000, Renaud Barbier wrote: > On 01/11/2013 13:02, Renaud Barbier wrote: > >>> Yes, You would have to have your i2c bus registered. Can't you move the > >>> >> above to late_initcall? > >>> >> > >>> >> Sascha > >>> >> > >> > > >> > I just did the following experiment: > >> > Move the code to device_initcall after the I2C registration and use the > >> > I2C API. Using the I2C API worked. However, when booting the board model > >> > is a NULL strings. > >> > > >> > So next I will check whether I can register the I2C device either in the > >> > postcore_initcall or when doing the console_initcall. > >> > > >> > Renaud. > > > I found a way to do it. This implies to: > - register the i2c-imx driver at the postcore initcall level. > - register the board i2c bus at the postcore initcall level > and perform the rest of the board initialization. > > > The i2c-imx driver is shared between architectures. If you do not > foresee any side-effects on the ARM architecture and this is acceptable > to you, I would like to submit a patch including this solution. Could you set the model to a superset of both possible boards initially, something like DA923RC/GBX460? Then set the correct board type in a late_initcall. The only thing affected is the printing of the board type in the banner, right? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox