From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ee0-x22a.google.com ([2a00:1450:4013:c00::22a]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VdUAb-0002A2-0O for barebox@lists.infradead.org; Tue, 05 Nov 2013 00:06:57 +0000 Received: by mail-ee0-f42.google.com with SMTP id c1so1080733eek.1 for ; Mon, 04 Nov 2013 16:06:35 -0800 (PST) Date: Tue, 5 Nov 2013 01:06:22 +0100 From: Alexander Aring Message-ID: <20131105000615.GA27728@omega> References: <1383606064-30494-1-git-send-email-a.heider@gmail.com> <1383606064-30494-2-git-send-email-a.heider@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1383606064-30494-2-git-send-email-a.heider@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2 1/6] fb: add a line_length value to struct fb_info To: Andre Heider Cc: barebox@lists.infradead.org On Tue, Nov 05, 2013 at 12:00:59AM +0100, Andre Heider wrote: > Add support for framebuffers with noncontiguous horizontal lines. > > Video drivers can set this value if the hardware requires it. > In case a driver does not set it, the current value of > xres * (bpp / 8) is used instead. > > Signed-off-by: Andre Heider > --- > drivers/video/fb.c | 11 +++++++++-- > include/fb.h | 1 + > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fb.c b/drivers/video/fb.c > index 420e4e3..0159994 100644 > --- a/drivers/video/fb.c > +++ b/drivers/video/fb.c > @@ -72,12 +72,16 @@ static int fb_setup_mode(struct device_d *dev, struct param_d *param, > > info->xres = info->mode->xres; > info->yres = info->mode->yres; > + info->line_length = 0; > > ret = info->fbops->fb_activate_var(info); > > + if (!info->line_length) > + info->line_length = info->xres * (info->bits_per_pixel >> 3); > + Isn't this already set from the register_framebuffer function? You wanna see that somebody changed this value in info->fbops->fb_activate_var(info)? Then I would do nothing here. - Alex _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox