Re: [PATCH 4/5] ppc: DA923RC: add board support

[Sascha Hauer <s.hauer@pengutronix.de>]

On Mon, Nov 04, 2013 at 06:06:29PM +0000, Renaud Barbier wrote:
> On 01/11/2013 20:28, Sascha Hauer wrote:
> 
> >>
> >> I found a way to do it. This implies to:
> >> - register the i2c-imx driver at the postcore initcall level.
> >> - register the board i2c bus at the postcore initcall level
> >>   and perform the rest of the board initialization.
> >>
> >>
> >> The i2c-imx driver is shared between architectures. If you do not
> >> foresee any side-effects on the ARM architecture and this is acceptable
> >> to you, I would like to submit a patch including this solution.
> > 
> > Could you set the model to a superset of both possible boards initially,
> > something like DA923RC/GBX460? Then set the correct board type in a
> > late_initcall. The only thing affected is the printing of the board type
> > in the banner, right?
> 
> Indeed, in this particular example, the only thing affected is the
> printing of the board name.
> However, reading the I2C early is not just for the board name.
> We have other variants of the board coming that may require minor
> adjustment (for instance DDR timing tuning) or early configuration.

I assume the timing has to be adjusted before the DDR can be used,
right? If so, then you have no other choice but to use some early i2c
stuff. Make sure though that it is only used as little as possible.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox