From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 1/6] fb: add a line_length value to struct fb_info
Date: Tue, 5 Nov 2013 09:00:57 +0100 [thread overview]
Message-ID: <20131105080057.GC24559@pengutronix.de> (raw)
In-Reply-To: <20131105000615.GA27728@omega>
On Tue, Nov 05, 2013 at 01:06:22AM +0100, Alexander Aring wrote:
> On Tue, Nov 05, 2013 at 12:00:59AM +0100, Andre Heider wrote:
> > Add support for framebuffers with noncontiguous horizontal lines.
> >
> > Video drivers can set this value if the hardware requires it.
> > In case a driver does not set it, the current value of
> > xres * (bpp / 8) is used instead.
> >
> > Signed-off-by: Andre Heider <a.heider@gmail.com>
> > ---
> > drivers/video/fb.c | 11 +++++++++--
> > include/fb.h | 1 +
> > 2 files changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/video/fb.c b/drivers/video/fb.c
> > index 420e4e3..0159994 100644
> > --- a/drivers/video/fb.c
> > +++ b/drivers/video/fb.c
> > @@ -72,12 +72,16 @@ static int fb_setup_mode(struct device_d *dev, struct param_d *param,
> >
> > info->xres = info->mode->xres;
> > info->yres = info->mode->yres;
> > + info->line_length = 0;
> >
> > ret = info->fbops->fb_activate_var(info);
> >
> > + if (!info->line_length)
> > + info->line_length = info->xres * (info->bits_per_pixel >> 3);
> > +
> Isn't this already set from the register_framebuffer function?
> You wanna see that somebody changed this value in info->fbops->fb_activate_var(info)?
>
> Then I would do nothing here.
It is set from register_framebuffer, but the mode setup invalidates it,
So Andre sets it to 0 first and updates it after calling into the driver
if necessary. The code looks correct. Maybe I misunderstand you?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-11-05 8:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 23:00 [PATCH v2 0/6] BCM2835 / simple framebuffer support Andre Heider
2013-11-04 23:00 ` [PATCH v2 1/6] fb: add a line_length value to struct fb_info Andre Heider
2013-11-05 0:06 ` Alexander Aring
2013-11-05 8:00 ` Sascha Hauer [this message]
2013-11-05 8:17 ` Alexander Aring
2013-11-05 8:48 ` Andre Heider
2013-11-05 8:58 ` Alexander Aring
2013-11-04 23:01 ` [PATCH v2 2/6] gui: convert graphic utils to respect line_length Andre Heider
2013-11-04 23:01 ` [PATCH v2 3/6] gui: convert the bmp renderer " Andre Heider
2013-11-04 23:01 ` [PATCH v2 4/6] ARM: bcm2835: add missing mbox overscan response field Andre Heider
2013-11-04 23:01 ` [PATCH v2 5/6] video: add a BCM2835 framebuffer driver Andre Heider
2013-11-04 23:01 ` [PATCH v2 6/6] video: set up the kernel's simple " Andre Heider
2013-11-06 9:46 ` [PATCH v2 0/6] BCM2835 / simple framebuffer support Sascha Hauer
2013-11-06 10:04 ` Alexander Aring
2013-11-06 10:02 ` Sascha Hauer
2013-11-06 10:18 ` Alexander Aring
2013-11-06 17:40 ` Andre Heider
2013-11-12 12:14 ` Andre Heider
2013-11-12 14:19 ` Sascha Hauer
2013-11-14 11:44 ` Andre Heider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131105080057.GC24559@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox