mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Rostislav Lisovy <lisovy@gmail.com>
Cc: barebox@lists.infradead.org, pisa@cmp.felk.cvut.cz
Subject: Re: [PATCH 3/3] ARM: i.mx53: Support for Voipac board. Device definition is read from Devicetree
Date: Fri, 8 Nov 2013 09:42:15 +0100	[thread overview]
Message-ID: <20131108084215.GU24559@pengutronix.de> (raw)
In-Reply-To: <1383662527-8538-4-git-send-email-lisovy@gmail.com>

Hi Rostislav,

On Tue, Nov 05, 2013 at 03:42:07PM +0100, Rostislav Lisovy wrote:
> Signed-off-by: Rostislav Lisovy <lisovy@gmail.com>
> 
> diff --git a/arch/arm/boards/freescale-mx53-vmx53/env/config b/arch/arm/boards/freescale-mx53-vmx53/env/config
> new file mode 100644
> index 0000000..3d90172
> --- /dev/null
> +++ b/arch/arm/boards/freescale-mx53-vmx53/env/config

Why not use defenv-2?

> diff --git a/arch/arm/boards/freescale-mx53-vmx53/flash_header.c b/arch/arm/boards/freescale-mx53-vmx53/flash_header.c
> new file mode 100644
> index 0000000..a6864a6
> --- /dev/null
> +++ b/arch/arm/boards/freescale-mx53-vmx53/flash_header.c

I'm currently generating the flash images for new boards using the
imx-image tool and also generate multi board images. This is a very
flexible, though maybe hard to understand mechanism. Is this the reason
you haven't used it or were you not aware of it?
I would rather see this board taking part in this new mechanism. Are you
willing to port this over? Otherwise I could try and convert this patch,
but I would depend on you testing the result.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-11-08  8:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05 14:42 [PATCH 0/3] Support for Voipac X53-DMM-668 module and Voipac Baseboard Rostislav Lisovy
2013-11-05 14:42 ` [PATCH 1/3] ARM: dts: i.mx53: Internal keyboard controller + i2c pinmux Rostislav Lisovy
2013-11-05 14:42 ` [PATCH 2/3] ARM: i.mx53: Parse Reset GPIO pin in FEC driver from Devicetree Rostislav Lisovy
2013-11-05 16:15   ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-05 19:11     ` Pavel Pisa
2013-11-06  8:39       ` Sascha Hauer
2013-11-05 14:42 ` [PATCH 3/3] ARM: i.mx53: Support for Voipac board. Device definition is read " Rostislav Lisovy
2013-11-08  8:42   ` Sascha Hauer [this message]
2013-11-09 22:14     ` Rostislav Lisovy
2013-11-11  9:54       ` Sascha Hauer
2013-11-12 22:57         ` Rostislav Lisovy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131108084215.GU24559@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=lisovy@gmail.com \
    --cc=pisa@cmp.felk.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox