mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Kumar Gala <galak@codeaurora.org>
Cc: barebox@lists.infradead.org, jbe@pengutronix.de,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] DT: Add binding for Altera FPGAs in passive-serial mode
Date: Tue, 12 Nov 2013 23:02:27 +0100	[thread overview]
Message-ID: <20131112220227.GO24559@pengutronix.de> (raw)
In-Reply-To: <C90E2E36-D168-4374-B420-38B2BB1914BD@codeaurora.org>

On Tue, Nov 12, 2013 at 10:21:02AM -0600, Kumar Gala wrote:
> 
> On Nov 12, 2013, at 8:31 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: devicetree@vger.kernel.org
> > ---
> > .../devicetree/bindings/firmware/altr,passive-serial.txt    | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/firmware/altr,passive-serial.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/firmware/altr,passive-serial.txt b/Documentation/devicetree/bindings/firmware/altr,passive-serial.txt
> > new file mode 100644
> > index 0000000..6d40c91
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/firmware/altr,passive-serial.txt
> > @@ -0,0 +1,13 @@
> > +Altera FPGAs in passive serial mode
> > +-----------------------------------
> > +
> > +This binding defines the control interface to Altera FPGAs in
> > +passive serial mode. This is used to upload the firmware and
> > +to start the FPGA.
> > +
> > +Required properties:
> > +- compatible: shall be "altr,passive-serial”
> 
> This doesn’t seem quite descriptive enough, easy to confuse with a serial port.

How about altr,fpga-passive-serial? Other suggestions?

> 
> > +- reg: SPI chip select
> 
> Is this a SPI device than?

Yes, it is.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-11-12 22:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 14:31 Sascha Hauer
2013-11-12 14:31 ` [PATCH 1/4] Add a Firmware programming framework Sascha Hauer
2013-11-12 14:31 ` [PATCH 2/4] Firmware: provide a handler to program Altera FPGAs Sascha Hauer
2013-11-12 14:46   ` Jürgen Beisert
2013-11-12 16:03   ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-13 10:23     ` Sascha Hauer
2013-11-13 13:36       ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-12 14:31 ` [PATCH 3/4] DT: Add binding for Altera FPGAs in passive-serial mode Sascha Hauer
2013-11-12 14:51   ` Jürgen Beisert
2013-11-12 16:21   ` Kumar Gala
2013-11-12 22:02     ` Sascha Hauer [this message]
2013-11-12 14:31 ` [PATCH 4/4] Firmware: socfpga: Add SoCFPGA FPGA program support Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131112220227.GO24559@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=jbe@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox