From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] scripts: kwboot: fix missing soh initialization
Date: Mon, 18 Nov 2013 10:53:48 +0100 [thread overview]
Message-ID: <20131118095348.GB24559@pengutronix.de> (raw)
In-Reply-To: <1384289884-8832-1-git-send-email-sebastian.hesselbarth@gmail.com>
On Tue, Nov 12, 2013 at 09:58:03PM +0100, Sebastian Hesselbarth wrote:
> Xmodem blocks should start with SOH but kwboot never sets the first
> block byte. This fixes kwboot's Xmodem block initialization and sets
> first block byte to SOH.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Applied, thanks
Sascha
> ---
> Cc: barebox@lists.infradead.org
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> scripts/kwboot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/kwboot.c b/scripts/kwboot.c
> index 33c94b3..81da3e8 100644
> --- a/scripts/kwboot.c
> +++ b/scripts/kwboot.c
> @@ -334,6 +334,7 @@ kwboot_xm_makeblock(struct kwboot_block *block, const void *data,
> size_t n;
> int i;
>
> + block->soh = SOH;
> block->pnum = pnum;
> block->_pnum = ~block->pnum;
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-11-18 9:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 20:58 Sebastian Hesselbarth
2013-11-12 20:58 ` [PATCH 2/2] scripts: kwbimage: fix mis-sized payload Sebastian Hesselbarth
2013-11-18 9:53 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118095348.GB24559@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox