From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] console: add is_ready callbback support
Date: Fri, 22 Nov 2013 08:03:18 +0100 [thread overview]
Message-ID: <20131122070318.GG24559@pengutronix.de> (raw)
In-Reply-To: <1384951152-2902-1-git-send-email-plagnioj@jcrosoft.com>
On Wed, Nov 20, 2013 at 01:39:11PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Some console such as net console need some parameter to work (IP & Port).
> So we can not enable them if not present.
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> common/console.c | 3 +++
> include/console.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/common/console.c b/common/console.c
> index 56bc864..32c5d38 100644
> --- a/common/console.c
> +++ b/common/console.c
> @@ -62,6 +62,9 @@ static int console_std_set(struct device_d *dev, struct param_d *param,
> char active[4];
> unsigned int flag = 0, i = 0;
>
> + if (cdev->is_ready && !cdev->is_ready(cdev))
> + return -EIO;
Instead of asking whether a console is ready please add a ->set_active
callback and pass the CONSOLE_* flags.
Sascha
> +
> if (val) {
> if (strchr(val, 'i') && cdev->getc) {
> active[i++] = 'i';
> diff --git a/include/console.h b/include/console.h
> index 550b440..b4caf55 100644
> --- a/include/console.h
> +++ b/include/console.h
> @@ -37,6 +37,7 @@ struct console_device {
> struct device_d *dev;
> struct device_d class_dev;
>
> + int (*is_ready)(struct console_device *cdev);
> int (*tstc)(struct console_device *cdev);
> void (*putc)(struct console_device *cdev, char c);
> int (*getc)(struct console_device *cdev);
> --
> 1.8.4.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-11-22 7:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 12:26 [PATCH 0/2] fix net console support Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 12:39 ` [PATCH 1/2] console: add is_ready callbback support Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 12:39 ` [PATCH 2/2] net: netconsole: add is_ready support Jean-Christophe PLAGNIOL-VILLARD
2013-11-22 7:03 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131122070318.GG24559@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox