From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/6] ARM: introduce machine description
Date: Thu, 28 Nov 2013 20:00:43 +0100 [thread overview]
Message-ID: <20131128190043.GB27628@ns203013.ovh.net> (raw)
In-Reply-To: <20131128181908.GA8179@omega>
On 19:19 Thu 28 Nov , Alexander Aring wrote:
> Hi,
>
> there are only some little nitpicks... maybe not important.
>
> On Thu, Nov 28, 2013 at 07:06:43PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > This will allow to do not check in each board which machine we are running
> > from. This work on DT & non-DT board.
> >
> > If only one board is enable autoselect it
> >
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > arch/arm/cpu/Makefile | 2 +-
> > arch/arm/cpu/dtb.c | 8 +-
> > arch/arm/cpu/machine.c | 188 +++++++++++++++++++++++++++++++++++++
> > arch/arm/include/asm/barebox-arm.h | 8 ++
> > arch/arm/include/asm/mach/arch.h | 68 ++++++++++++++
> > arch/arm/lib/barebox.lds.S | 6 ++
> > 6 files changed, 277 insertions(+), 3 deletions(-)
> > create mode 100644 arch/arm/cpu/machine.c
> > create mode 100644 arch/arm/include/asm/mach/arch.h
> >
> > diff --git a/arch/arm/cpu/Makefile b/arch/arm/cpu/Makefile
> > index aba201b..78532da 100644
> ...
> > +
> > +int is_dt_compatible(const struct machine_desc *m, const char* dt_compat)
> > +{
> > + const char *const *dtc = m->dt_compat;
> const char *const *dtc? Looks like c ninja coding style :-D.
>
> I think you mean:
>
> const char **dtc = ...
>
no I mean this one both pointer are const It's very specific
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-11-28 18:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 18:05 [PATCH 0/6] ARM: machine struct support Jean-Christophe PLAGNIOL-VILLARD
2013-11-28 18:06 ` [PATCH 1/6] arm: gen-mach-types: add MAX_MACH_TYPE Jean-Christophe PLAGNIOL-VILLARD
2013-11-28 18:06 ` [PATCH 2/6] ARM: introduce machine description Jean-Christophe PLAGNIOL-VILLARD
2013-11-28 18:19 ` Alexander Aring
2013-11-28 19:00 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-11-28 19:02 ` Alexander Aring
2013-12-02 9:01 ` Sascha Hauer
2013-12-02 11:04 ` Jean-Christophe PLAGNIOL-VILLARD
2013-12-02 11:54 ` Sascha Hauer
2013-11-28 18:06 ` [PATCH 3/6] ARM: introduce SoC description Jean-Christophe PLAGNIOL-VILLARD
2013-11-28 18:06 ` [PATCH 4/6] AT91: detect SoC earlier Jean-Christophe PLAGNIOL-VILLARD
2013-11-28 18:06 ` [PATCH 5/6] AT91: switch to machine description Jean-Christophe PLAGNIOL-VILLARD
2013-11-28 18:06 ` [PATCH 6/6] vexpress: " Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128190043.GB27628@ns203013.ovh.net \
--to=plagnioj@jcrosoft.com \
--cc=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox