From: Sascha Hauer <s.hauer@pengutronix.de>
To: Kevin Du Huanpeng <u74147@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [Makefile bug] make barebox.s : dead loop
Date: Mon, 2 Dec 2013 10:13:20 +0100 [thread overview]
Message-ID: <20131202091320.GF24559@pengutronix.de> (raw)
In-Reply-To: <CANvTkNaxQS489FzWdyozrKnXHeACd5PnCB05GVgMqm82-jBGPg@mail.gmail.com>
On Mon, Dec 02, 2013 at 04:36:50PM +0800, Kevin Du Huanpeng wrote:
> I add barebox.s after the target barebox.S,
> It works.
> maybe should add the same thing with
>
> ----------
> ifdef CONFIG_X86
> barebox.S: barebox
> ifdef CONFIG_X86_HDBOOT
> ------------
>
>
> @@ -723,7 +724,7 @@ endif
> @echo " * Init Calls content" >> barebox.S
> $(Q)$(OBJDUMP) -j .barebox_initcalls -d barebox >> barebox.S
> else
> -barebox.S: barebox FORCE
> +barebox.S barebox.s: barebox FORCE
> $(call if_changed,disasm)
Normally you are supposed to call 'make barebox.S' (with uppercase 'S'),
but I think it's fine to just add the same target with a lowercase 's'
like you did to make both work. Care to send a proper patch with
Signed-off-by?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-12-02 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 8:22 Kevin Du Huanpeng
2013-12-02 8:36 ` Kevin Du Huanpeng
2013-12-02 9:13 ` Sascha Hauer [this message]
2013-12-02 12:27 ` Kevin Du Huanpeng
2013-12-03 11:25 ` Sascha Hauer
2013-12-04 14:17 ` Kevin Du Huanpeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202091320.GF24559@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u74147@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox