mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Antony Pavlov <antonynpavlov@gmail.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [JUST RFC] ARM: DIGIC: add csrc-dummy
Date: Mon, 16 Dec 2013 00:40:13 +0400	[thread overview]
Message-ID: <20131216004013.1c656aafb428cfe6df3e4ed8@gmail.com> (raw)
In-Reply-To: <20131215193015.GA539@omega>

On Sun, 15 Dec 2013 20:30:16 +0100
Alexander Aring <alex.aring@gmail.com> wrote:

> Hi Antony,
> 
> On Sun, Dec 15, 2013 at 07:02:05PM +0400, Antony Pavlov wrote:
> > The clocksource csrc-timer driver that uses DIGIC
> > hardware TIMER2 perfectrly works on Canon A1100,
> > but does not works on Canon EOS 600D.
> > IMHO we need additional timer initialisation.
> > 
> > This patch introduces a quick-and-dirty termporary
> > solution for this situation: a clocksource driver that
> > does not use any hardware at all.
> > 
> > Also this driver is very handy for running barebox
> > on Magic Lantern EOS qemu-based emulator as
> > the emulator does not realize timer counter register at all!
> > 
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> >  arch/arm/mach-digic/Kconfig      |  3 +++
> >  arch/arm/mach-digic/Makefile     |  1 +
> >  arch/arm/mach-digic/csrc-dummy.c | 49 ++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 53 insertions(+)
> >  create mode 100644 arch/arm/mach-digic/csrc-dummy.c
> > 
> > diff --git a/arch/arm/mach-digic/Kconfig b/arch/arm/mach-digic/Kconfig
> > index 557cad4..d0524bc 100644
> > --- a/arch/arm/mach-digic/Kconfig
> > +++ b/arch/arm/mach-digic/Kconfig
> > @@ -16,4 +16,7 @@ config ARCH_TEXT_BASE
> >  config DIGIC_CSRC_TIMER
> >  	bool
> >  
> > +config DIGIC_CSRC_DUMMY
> > +	bool
> > +
> >  endif
> > diff --git a/arch/arm/mach-digic/Makefile b/arch/arm/mach-digic/Makefile
> > index 1d7cb72..31e5ac1 100644
> > --- a/arch/arm/mach-digic/Makefile
> > +++ b/arch/arm/mach-digic/Makefile
> > @@ -1,2 +1,3 @@
> >  obj-y += core.o
> >  obj-$(CONFIG_DIGIC_CSRC_TIMER) += csrc-timer.o
> > +obj-$(CONFIG_DIGIC_CSRC_DUMMY) += csrc-dummy.o
> > diff --git a/arch/arm/mach-digic/csrc-dummy.c b/arch/arm/mach-digic/csrc-dummy.c
> > new file mode 100644
> > index 0000000..68c68a3
> > --- /dev/null
> > +++ b/arch/arm/mach-digic/csrc-dummy.c
> > @@ -0,0 +1,49 @@
> > +/*
> > + * Copyright (C) 2013 Antony Pavlov <antonynpavlov@gmail.com>
> > + *
> > + * This file is part of barebox.
> > + * See file CREDITS for list of people who contributed to this project.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2
> > + * as published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + */
> > +
> > +#include <init.h>
> > +#include <clock.h>
> > +
> > +#include <stdio.h>
> > +
> > +static uint64_t dummy_counter;
> > +
> > +static uint64_t dummy_cs_read(void)
> > +{
> > +	dummy_counter += 2000;
> > +	return dummy_counter;
> > +}
> > +
> So if I understand it right, you assume here that the instructions to
> read this value will take 0.02 ms?

It is not quite. I don't assume initially the time to read this value.
This value ("2000") was a suboptimal value for __specific board__
under the __specific circumstances__.
I have selected this value after several experiments.

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-12-15 20:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-15 15:02 [JUST RFC] add hardware independent clock source Antony Pavlov
2013-12-15 15:02 ` [JUST RFC] ARM: DIGIC: add csrc-dummy Antony Pavlov
2013-12-15 18:08   ` Alexander Shiyan
2013-12-15 18:52     ` Antony Pavlov
2013-12-15 18:50       ` Alexander Shiyan
2013-12-15 19:30   ` Alexander Aring
2013-12-15 20:40     ` Antony Pavlov [this message]
2013-12-15 21:17       ` Alexander Aring
2013-12-16  7:41   ` Sascha Hauer
2013-12-16  7:46     ` Alexander Aring
2013-12-16  7:48     ` Alexander Shiyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131216004013.1c656aafb428cfe6df3e4ed8@gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox