From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/5] miitool: change behaviour closer to linux' mii-tool
Date: Mon, 6 Jan 2014 09:52:43 +0100 [thread overview]
Message-ID: <20140106085242.GC24559@pengutronix.de> (raw)
In-Reply-To: <1387957805-1532-2-git-send-email-antonynpavlov@gmail.com>
On Wed, Dec 25, 2013 at 11:50:01AM +0400, Antony Pavlov wrote:
> miitool without arguments will try to show status for all phys.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> +static void mdiobus_show(struct device_d *dev, char *phydevname, int verbose)
> +{
> + struct mii_bus *mii = to_mii_bus(dev);
> + int i, ret;
Applied this series with this unused variable removed...
> @@ -227,9 +244,6 @@ static int do_miitool(int argc, char *argv[])
> case 'v':
> verbose++;
> break;
> - case 's':
> - scan = 1;
> - break;
...and also removed 's' from the options string.
This behaviour looks definitely better than what I did with the
additional 's' option.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-01-06 8:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-25 7:50 [PATCH 0/5] miitool patches Antony Pavlov
2013-12-25 7:50 ` [PATCH 1/5] miitool: change behaviour closer to linux' mii-tool Antony Pavlov
2014-01-06 8:52 ` Sascha Hauer [this message]
2013-12-25 7:50 ` [PATCH 2/5] miitool: add initial GbE support Antony Pavlov
2013-12-25 7:50 ` [PATCH 3/5] miitool: drop internal table of known MII, use phy drivers instead Antony Pavlov
2013-12-25 7:50 ` [PATCH 4/5] net/phy: add driver for LXT PHYs Antony Pavlov
2013-12-25 7:50 ` [PATCH 5/5] net/phy/phy.c: fix whitespace Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106085242.GC24559@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox