From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jan Weitzel <J.Weitzel@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] of: find also nodes by mixture of alias and path
Date: Mon, 6 Jan 2014 11:50:52 +0100 [thread overview]
Message-ID: <20140106105052.GE3677@pengutronix.de> (raw)
In-Reply-To: <1389004019.3306.2.camel@lws-weitzel>
On Mon, Jan 06, 2014 at 11:26:59AM +0100, Jan Weitzel wrote:
> Am Montag, den 06.01.2014, 10:32 +0100 schrieb Sascha Hauer:
> > Hi Jan,
> >
> > On Fri, Dec 20, 2013 at 02:24:48PM +0100, Jan Weitzel wrote:
> > > Let of_find_node_by_path_or_alias also find a node starting with an alias
> > > followed by a path like "i2c0/tps@24"
> > >
> > > Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
> > > ---
> > > v2: rename ret to node
> > >
> > > drivers/of/base.c | 22 +++++++++++++++++++++-
> > > 1 files changed, 21 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/of/base.c b/drivers/of/base.c
> > > index ea2d879..5b5272d 100644
> > > --- a/drivers/of/base.c
> > > +++ b/drivers/of/base.c
> > > @@ -1378,11 +1378,31 @@ EXPORT_SYMBOL(of_find_node_by_path);
> > > struct device_node *of_find_node_by_path_or_alias(struct device_node *root,
> > > const char *str)
> > > {
> > > + struct device_node *node;
> > > + char *slash, *alias;
> > > + size_t len = 0;
> > > +
> > > if (*str == '/')
> > > return of_find_node_by_path_from(root, str);
> > > - else
> > > +
> > > + slash = _strchr(str, '/');
> >
> > You should use regular strchr, not _strchr. Or is there any reason to do
> > it differently here?
> I got this from the strchr wrapper:
>
> drivers/of/base.c: In function 'of_find_node_by_path_or_alias':
> drivers/of/base.c:1388:8: warning: assignment discards 'const' qualifier
> from pointer target type [enabled by default]
>
> Is there a cleaner way?
Try making 'slash' const.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-01-06 10:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 8:39 [PATCH] " Jan Weitzel
2013-12-20 13:24 ` [PATCH v2] " Jan Weitzel
2014-01-06 9:32 ` Sascha Hauer
2014-01-06 10:26 ` Jan Weitzel
2014-01-06 10:50 ` Sascha Hauer [this message]
2014-01-06 12:45 ` [PATCH v3] " Jan Weitzel
2014-01-10 9:40 ` Sascha Hauer
2014-01-06 12:46 ` [PATCH v2] " Jan Weitzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106105052.GE3677@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=J.Weitzel@phytec.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox