From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] ARM: dts: i.MX53: tqma53: Add barebox specifics
Date: Tue, 21 Jan 2014 09:17:55 +0100 [thread overview]
Message-ID: <20140121081755.GV16215@pengutronix.de> (raw)
In-Reply-To: <20140120182549.GA29762@omega>
On Mon, Jan 20, 2014 at 07:25:50PM +0100, Alexander Aring wrote:
> Hi Sascha,
>
> On Mon, Jan 20, 2014 at 02:23:55PM +0100, Sascha Hauer wrote:
> > - add chosen node with
> > - environment
> > - linux,stdout-path
> > - add dsr value to eMMC
> > - add provide-mac-address property to iim node
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > arch/arm/dts/imx53-mba53.dts | 17 +++++++++++++++++
> > arch/arm/dts/imx53-tqma53.dtsi | 15 ++++++++++++++-
> > 2 files changed, 31 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/dts/imx53-mba53.dts b/arch/arm/dts/imx53-mba53.dts
> > index a630902..43bb12c 100644
> ...
> > +
> > memory {
> > - reg = <0x70000000 0x40000000>; /* Up to 1GiB */
> > + reg = <0x70000000 0x0>; /* Up to 1GiB */
>
> Is this change correct? You don't mention it in commit-msg and it confusing
> me a little bit to set this zero. :-)
The change is necessary. The tqma53 comes with 512MiB or 1GiB. During
barebox startup the SDRAM first gets registered by the devicetree
information, but this is wrong for the 512MiB boards. The correct
SDRAM size is derived from the SDRAM controller settings later from
arch/arm/mach-imx/esdctl.c. This only works as long as the devicetree
parser hasn't registered conflicting SDRAM earlier.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-01-21 8:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 13:23 TQ tqma53 devicetree support Sascha Hauer
2014-01-20 13:23 ` [PATCH 1/3] ARM: dts: Add TQ tqma53/mba53 dts files Sascha Hauer
2014-01-20 13:23 ` [PATCH 2/3] ARM: dts: i.MX53: tqma53: Add barebox specifics Sascha Hauer
2014-01-20 18:25 ` Alexander Aring
2014-01-21 8:17 ` Sascha Hauer [this message]
2014-01-22 6:33 ` Sascha Hauer
2014-01-22 9:41 ` Alexander Aring
2014-01-20 13:23 ` [PATCH 3/3] ARM: i.MX53: tqma53: Switch to devicetree and multiboard support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121081755.GV16215@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox