mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Cristiano De Alti <cristiano_dealti@hotmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: i.mx21 ads nor flash
Date: Mon, 3 Feb 2014 09:35:07 +0100	[thread overview]
Message-ID: <20140203083506.GF16215@pengutronix.de> (raw)
In-Reply-To: <loom.20140202T170955-777@post.gmane.org>

On Sun, Feb 02, 2014 at 04:17:22PM +0000, Cristiano De Alti wrote:
> Sascha Hauer <s.hauer@...> writes:
> 
> > 
> +CONFIG_FS_TFTP=y
> diff --git a/drivers/mtd/nor/cfi_flash.c b/drivers/mtd/nor/cfi_flash.c
> index 71dd3c8..514eab5 100644
> --- a/drivers/mtd/nor/cfi_flash.c
> +++ b/drivers/mtd/nor/cfi_flash.c
> @@ -404,9 +404,9 @@ static ulong flash_get_size (struct flash_info *info)
>                                 erase_region_count, erase_region_size);
>  
>                         region->offset = cur_offset;
> -                       region->erasesize = erase_region_size;
> +                       region->erasesize = erase_region_size * size_ratio;
>                         region->numblocks = erase_region_count;
> -                       cur_offset += erase_region_size * erase_region_count;
> +                       cur_offset += erase_region_size * size_ratio *
> erase_region_count;

The patch looks correct. Could you split the patch into two, one with
the defconfig changes and one with the flash fix and send both with a
"<Signed-off-by>: Cristiano De Alti <cristiano_dealti@hotmail.com>" tag?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2014-02-03  8:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-27 23:46 Cristiano De Alti
2014-01-28 11:33 ` Sascha Hauer
2014-02-02 16:17   ` Cristiano De Alti
2014-02-03  8:35     ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140203083506.GF16215@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=cristiano_dealti@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox