mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/7] ARM: mx53-qsrb: enable USB OTG in host mode
Date: Mon, 10 Feb 2014 09:37:15 +0100	[thread overview]
Message-ID: <20140210093715.032a0db5@e6520eb> (raw)
In-Reply-To: <20140210083148.GG17250@pengutronix.de>

Le Mon, 10 Feb 2014 09:31:48 +0100,
Sascha Hauer <s.hauer@pengutronix.de> a écrit :

> On Mon, Feb 10, 2014 at 09:28:54AM +0100, Eric Bénard wrote:
> > Hi Sascha,
> > 
> > Le Mon, 10 Feb 2014 09:16:17 +0100,
> > Sascha Hauer <s.hauer@pengutronix.de> a écrit :
> > > On Sat, Feb 08, 2014 at 03:16:10PM +0100, Eric Bénard wrote:
> > > >  &usbotg {
> > > > -       status = "okay";
> > > > +	phy_type = "utmi";
> > > > +	dr_mode = "host";
> > > > +	status = "okay";
> > > >  };
> > > 
> > > Do we need a barebox specific option to specify dr_mode? I mean barebox
> > > cannot do otg, so we need to specify dr_mode to host or device, but with
> > > the above change Linux is limited to host mode aswell.
> > > 
> > in chipidea-imx.c there is :
> > 
> > 	mode = of_usb_get_dr_mode(ci->dev->device_node, NULL);
> > 
> > 	switch (mode) {
> > 	case USB_DR_MODE_HOST:
> > 	default:
> > 		ci->mode = IMX_USB_MODE_HOST;
> > 		break;
> > 	case USB_DR_MODE_PERIPHERAL:
> > 		ci->mode = IMX_USB_MODE_DEVICE;
> > 		break;
> > 	}
> > 
> > so we could omit the dr_mode=host as it will default to host.
> 
> Then let's do this. The default-to-host beahaviour in barebox may not
> be desirable in all cases, but at least we do not propagate this
> behaviour to the kernel.
> 
do you want a v2 or will you remove the line when applying ?

Eric

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-02-10  8:37 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-08 14:16 [PATCH 1/7] sata-imx: i.MX53, use the internal 120MHz clock by default Eric Bénard
2014-02-08 14:16 ` [PATCH 2/7] ARM: i.MX53: Add sata to devicetree Eric Bénard
2014-02-08 14:26   ` Alexander Shiyan
2014-02-10  8:33     ` Sascha Hauer
2014-02-10  8:39       ` Eric Bénard
2014-02-10  8:40       ` Alexander Shiyan
2014-02-10  8:48         ` Eric Bénard
2014-02-10  8:52           ` Sascha Hauer
2014-02-10  8:54             ` Eric Bénard
2014-02-10  9:03               ` Sascha Hauer
2014-02-10  9:11                 ` Sascha Hauer
2014-03-07 10:39                   ` [PATCH v2 1/7] sata-imx: i.MX53, use the internal 120MHz clock by default Eric Bénard
2014-03-07 10:39                     ` [PATCH v2 2/7] ARM: i.MX53: Add sata to devicetree Eric Bénard
2014-03-10  7:08                       ` Sascha Hauer
2014-03-07 10:39                     ` [PATCH v2 3/7] ARM: mx53-qsrb: fix USB Eric Bénard
2014-03-07 10:40                     ` [PATCH v2 4/7] ARM: mx53-qsrb: enable USB host Eric Bénard
2014-03-07 10:40                     ` [PATCH v2 5/7] ARM: mx53-qsrb: enable USB OTG in host mode Eric Bénard
2014-03-07 10:40                     ` [PATCH v2 6/7] ARM: mx53-qsrb: enable sata Eric Bénard
2014-03-07 10:40                     ` [PATCH v2 7/7] ARM: mx53-qsb: update defconfig Eric Bénard
2014-03-10  7:09                     ` [PATCH v2 1/7] sata-imx: i.MX53, use the internal 120MHz clock by default Sascha Hauer
2014-03-10  7:51                       ` Eric Bénard
2014-03-11  5:32                         ` Sascha Hauer
2014-02-10  9:07     ` [PATCH 2/7] ARM: i.MX53: Add sata to devicetree Sascha Hauer
2014-02-10  9:15       ` Sascha Hauer
2014-02-10  9:22         ` Alexander Shiyan
2014-02-08 14:16 ` [PATCH 3/7] ARM: mx53-qsrb: fix USB Eric Bénard
2014-02-08 14:16 ` [PATCH 4/7] ARM: mx53-qsrb: enable USB host Eric Bénard
2014-02-08 14:16 ` [PATCH 5/7] ARM: mx53-qsrb: enable USB OTG in host mode Eric Bénard
2014-02-10  8:16   ` Sascha Hauer
2014-02-10  8:28     ` Eric Bénard
2014-02-10  8:31       ` Sascha Hauer
2014-02-10  8:37         ` Eric Bénard [this message]
2014-02-08 14:16 ` [PATCH 6/7] ARM: mx53-qsrb: enable sata Eric Bénard
2014-02-08 14:16 ` [PATCH 7/7] ARM: mx53-qsb: update defconfig Eric Bénard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140210093715.032a0db5@e6520eb \
    --to=eric@eukrea.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox