From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WIgq8-0004Ao-Eo for barebox@lists.infradead.org; Wed, 26 Feb 2014 15:56:09 +0000 Date: Wed, 26 Feb 2014 16:55:46 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Message-ID: <20140226155546.GJ6865@pengutronix.de> References: <1393368681-1190-1-git-send-email-u.kleine-koenig@pengutronix.de> <1393368681-1190-7-git-send-email-u.kleine-koenig@pengutronix.de> <530D2660.6080104@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <530D2660.6080104@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 06/10] ARM: a9m2410: convert to devfs_create_partitions To: Sebastian Hesselbarth Cc: barebox@lists.infradead.org On Wed, Feb 26, 2014 at 12:25:20AM +0100, Sebastian Hesselbarth wrote: > On 02/25/2014 11:51 PM, Uwe Kleine-K=F6nig wrote: > >Signed-off-by: Uwe Kleine-K=F6nig > >--- > > arch/arm/boards/a9m2410/a9m2410.c | 23 +++++++++++++++++------ > > 1 file changed, 17 insertions(+), 6 deletions(-) > > > >diff --git a/arch/arm/boards/a9m2410/a9m2410.c b/arch/arm/boards/a9m2410= /a9m2410.c > >index b2b6c87117a3..8d528cf60378 100644 > >--- a/arch/arm/boards/a9m2410/a9m2410.c > >+++ b/arch/arm/boards/a9m2410/a9m2410.c > >@@ -117,13 +117,24 @@ static int a9m2410_devices_init(void) > > 16, IORESOURCE_MEM, NULL); > > > > #ifdef CONFIG_NAND > >- /* ----------- add some vital partitions -------- */ > >- devfs_add_partition("nand0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, = "self_raw"); > >- dev_add_bb_dev("self_raw", "self0"); > >- > >- devfs_add_partition("nand0", 0x40000, 0x20000, DEVFS_PARTITION_FIXED, = "env_raw"); > >- dev_add_bb_dev("env_raw", "env0"); > >+ devfs_create_partitions("nand0", (struct devfs_partition[]){ > = > nit: It would be even more readable, if you move the struct > devfs_partition[] out of a9m2410_device_init() and reference > it here instead, i.e. > = > static struct devfs_partition a9m2410_nand_partitions[] =3D { > ... > { } > }; nit: I'd add "const" here. And you'd need something to not let the compiler generate a "a9m2410_nand_partitions not used" warning if CONFIG_NAND is disabled. Another (related) upside of using compound literals as I did is that "nand0" and the respecitve partition array is to be found at the same place. But having said that I don't really care how the boards are converted. If you want your approach, fine for me. (Ideally send a patch yourself, you can get my Ack then :-) Best regards Uwe > ... > = > static int a9m2410_devices_init(void) > { > ... > #ifdef CONFIG_NAND > devfs_create_partitions("nand0", a9m2410_nand_partitions); > #endif > ... > = > in here and the following patches. > = > Sebastian > = > >+ { > >+ .offset =3D 0, > >+ .size =3D 0x40000, > >+ .flags =3D DEVFS_PARTITION_FIXED, > >+ .name =3D "self_raw", > >+ .bbname =3D "self0", > >+ }, { > >+ .offset =3D DEVFS_PARTITION_APPEND, > >+ .size =3D 0x20000, > >+ .flags =3D DEVFS_PARTITION_FIXED, > >+ .name =3D "env_raw", > >+ .bbname =3D "env0", > >+ }, { > >+ /* sentinel (detected by .name =3D NULL) */ > >+ }}); > > #endif > >+ > > armlinux_set_architecture(MACH_TYPE_A9M2410); > > > > return 0; > > > = > = > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox