mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 00/10] new partitioning helper
Date: Fri, 28 Feb 2014 08:25:48 +0100	[thread overview]
Message-ID: <20140228072548.GT17250@pengutronix.de> (raw)
In-Reply-To: <1393533550-1865-1-git-send-email-u.kleine-koenig@pengutronix.de>

On Thu, Feb 27, 2014 at 09:39:00PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> this is v2 of the series introducing devfs_create_partitions. With the
> new syntax creating partitions is easier to parse for humans, it has
> support to create partitions without holes inbetween without the need to
> explicitly calculate the offsets and the code generated for the callers
> is smaller.
> 
> I compared the size of arch/arm/boards/a9m2410/a9m2410.o with and
> without the series with the kernel's bloat-o-meter, with the following
> result:
> 
> add/remove: 1/0 grow/shrink: 0/1 up/down: 84/-104 (-20)
> function                                     old     new   delta
> a9m2410_nand0_partitions                       -      84     +84
> a9m2410_devices_init                         296     192    -104
> 
> (Well, the size advantage is a *bit* relativized by the growth of fs/devfs-core.o:
> 
> add/remove: 3/0 grow/shrink: 0/1 up/down: 508/-124 (384)
> function                                     old     new   delta
> __devfs_add_partition.part                     -     376    +376
> devfs_create_partitions                        -     128    +128
> new                                            -       4      +4
> devfs_add_partition                          296     172    -124
> 
> Don't know what "new" is above.)
> 
> Compared to (implicit) v1 of this series I dropped the compound
> literals and used named static arrays instead as wished by Sebastian
> Hesselbarth and Sascha Hauer.

Applied this series. I skipped the pca100 patch as this one has the
partition layout in the devicetree now.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2014-02-28  7:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27 20:39 Uwe Kleine-König
2014-02-27 20:39 ` [PATCH v2 01/10] devfs: partitioning: add missing free in error path Uwe Kleine-König
2014-02-27 20:39 ` [PATCH v2 02/10] devfs_add_partition: make flags parameter unsigned Uwe Kleine-König
2014-02-27 20:39 ` [PATCH v2 03/10] Documentation: fix example call to devfs_add_partition Uwe Kleine-König
2014-02-27 20:39 ` [PATCH v2 04/10] mtd/nand: constify filename parameter Uwe Kleine-König
2014-02-27 20:39 ` [PATCH v2 05/10] devfs: partitioning: add new helper devfs_create_partitions Uwe Kleine-König
2014-02-27 20:39 ` [PATCH v2 06/10] ARM: a9m2410: convert to devfs_create_partitions Uwe Kleine-König
2014-02-27 20:41   ` Sebastian Hesselbarth
2014-02-27 20:39 ` [PATCH v2 07/10] ARM: freescale-mx35-3-stack: " Uwe Kleine-König
2014-02-27 20:39 ` [PATCH v2 08/10] ARM: pca100: " Uwe Kleine-König
2014-02-27 20:39 ` [PATCH v2 09/10] ARM: pcm038: " Uwe Kleine-König
2014-02-27 20:39 ` [PATCH v2 10/10] ARM: sama5d3xek: " Uwe Kleine-König
2014-02-28  7:25 ` Sascha Hauer [this message]
2014-02-28  7:45   ` [PATCH v2 00/10] new partitioning helper Sascha Hauer
2014-02-28 14:09     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140228072548.GT17250@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox