From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WJOJo-0006JK-VE for barebox@lists.infradead.org; Fri, 28 Feb 2014 14:21:41 +0000 Date: Fri, 28 Feb 2014 15:21:18 +0100 From: Sascha Hauer Message-ID: <20140228142118.GF17250@pengutronix.de> References: <1393573468-31105-1-git-send-email-alex.aring@gmail.com> <1393573468-31105-4-git-send-email-alex.aring@gmail.com> <20140228080333.GA31407@omega> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140228080333.GA31407@omega> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [RFC 3/3] libbb: read_full: use read return instead size To: Alexander Aring Cc: barebox@lists.infradead.org On Fri, Feb 28, 2014 at 09:03:34AM +0100, Alexander Aring wrote: > On Fri, Feb 28, 2014 at 08:44:28AM +0100, Alexander Aring wrote: > > Signed-off-by: Alexander Aring > > --- > > lib/libbb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/libbb.c b/lib/libbb.c > > index 189a170..c8d0835 100644 > > --- a/lib/libbb.c > > +++ b/lib/libbb.c > > @@ -162,7 +162,7 @@ int read_full(int fd, void *buf, size_t size) > > int now; > > int total = 0; > > > > - while (size) { > > + while (now) { > > now = read(fd, buf, size); > > if (now == 0) > > return total; > and this should be a: > > do { > ... > } while (now); > > sry, it's only to demonstrate the issue. 'now' will never be 0 at the end of the loop, so you could equally well write while(1). With this change we try to read as long as we read something last time, even if there's nothing left to read (size is 0). What issue do you see with this function? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox