From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WKOMc-0006x0-Jx for barebox@lists.infradead.org; Mon, 03 Mar 2014 08:36:43 +0000 Date: Mon, 3 Mar 2014 09:36:20 +0100 From: Sascha Hauer Message-ID: <20140303083620.GN17250@pengutronix.de> References: <1393573468-31105-1-git-send-email-alex.aring@gmail.com> <1393573468-31105-2-git-send-email-alex.aring@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1393573468-31105-2-git-send-email-alex.aring@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [RFC 1/3] ramfs: add foofs for testing To: Alexander Aring Cc: barebox@lists.infradead.org On Fri, Feb 28, 2014 at 08:44:26AM +0100, Alexander Aring wrote: > Signed-off-by: Alexander Aring > --- > fs/ramfs.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/fs/ramfs.c b/fs/ramfs.c > index f45a454..4b93c2e 100644 > --- a/fs/ramfs.c > +++ b/fs/ramfs.c > @@ -608,6 +608,48 @@ static int ramfs_probe(struct device_d *dev) > return 0; > } > > +static int foofs_read(struct device_d *_dev, FILE *f, void *buf, size_t insize) > +{ > + if (f->pos == strlen("Hello World!\n")) > + return 0; > + > + return sprintf(buf, "%s", "Hello World!\n"); > +} You should never read more bytes than insize. This is also true for insize == 0. Implement this correctly and you'll see that your patches do not solve the problem. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox